Update content model for customizable select #10586
Conversation
This PR updated the content model for the <select>, <option>, and <optgroup> elements in support of customizable <select>. Fixes whatwg#10317
josepharhar
force-pushed
the
selectcontentmodel
branch
from
20549ca
to
088b919
Compare
|
Is the idea to allow If the former, you need to change the definition of phrasing content to include " If the latter, you need to change the content model if |
source
Outdated
| <dd>Zero or more <span>select element inner content elements</span>.</dd> | ||
| <dd>Zero or one child <code>button</code>.</dd> |
There was a problem hiding this comment.
| <dd>Zero or more <span>select element inner content elements</span>.</dd> | |
| <dd>Zero or one child <code>button</code>.</dd> | |
| <dd>Zero or more <span>select element inner content elements</span>, followed by zero or one | |
| <code>button</code> element.</dd> |
There was a problem hiding this comment.
The button should probably go first, and I wanted to keep the "zero or one" concept with the button, so I wrote it like this:
<dd>Zero or one <code>button</code> element followed by zero or more <span>select element inner content elements</span>.</dd>
Look good?
source
Outdated
| <dd>If the element has no <code data-x="attr-option-label">label</code> attribute and is a child | ||
| of a <code>datalist</code> element: <span data-x="text content">Text</span>.</dd> | ||
| <dd>If the element has no <code data-x="attr-option-label">label</code> attribute: <span>Text content</span> and zero or more <code>div</code>, <code>span</code>, <code>noscript</code>, <code>img</code>, <span>SVG <code>svg</code></span>, and <span data-x="script-supporting elements">script-supporting</span> elements.</dd> | ||
| <dd><div class="note">If an <code>img</code> is used within an <code>option</code> and there is no other text within the <code>option</code>, then the <code>option</code> won't have an accessible name unless the <code>img</code> also has a non-empty <code data-x="attr-img-alt">alt</code> attribute.</div></dd> |
There was a problem hiding this comment.
Don't have notes in the "element" box, put it further down along with the prose about the content model. The note is also not correct, so maybe it's better to remove it?
There was a problem hiding this comment.
I thought this was what @scottaohara suggested, but as per this comment, it sounds like we can add notes and examples as a follow up. I removed the note for now.
There was a problem hiding this comment.
besides the placement could you elaborate on what was wrong with the note @zcorpan? i might have phrased it a bit differently, but it seemed to be saying <option><img src=...></option> would have no accessible name, and that is correct.
|
|
||
| <li><code>span</code> elements.</li> | ||
|
|
||
| <li><code>img</code> elements.</li> |
There was a problem hiding this comment.
Is the idea to allow img between options?
There was a problem hiding this comment.
Yes. @scottaohara do you think this should be forbidden?
There was a problem hiding this comment.
i think people will generally just want images within their options. they'll probably also sometimes want to use them within the legend for optgroups. If it were just up to me, i'd limit their use to being children of these elements.
per discussions that were had on this, the primary use case people seemed to think authors might want them for, outside of options, would be for decorative reasons. but i don't see why that couldn't be done with the allowed divs/spans and CSS.
h1 elements are not supposed to be part of the content model, so I implemented the div and span switching by pulling out the content models for option and optgroup and using them in div and span. |
This PR updated the content model for the
<select>,<option>, and<optgroup>elements in support of customizable<select>.Fixes #10317
(See WHATWG Working Mode: Changes for more details.)
/dom.html ( diff )
/embedded-content.html ( diff )
/form-elements.html ( diff )
/grouping-content.html ( diff )
/index.html ( diff )
/scripting.html ( diff )
/text-level-semantics.html ( diff )