Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowed to download shouldn't consult browsing contexts #5597

Closed
annevk opened this issue Jun 2, 2020 · 1 comment · Fixed by #6315
Closed

Allowed to download shouldn't consult browsing contexts #5597

annevk opened this issue Jun 2, 2020 · 1 comment · Fixed by #6315

Comments

@annevk
Copy link
Member

annevk commented Jun 2, 2020

They have no authority, documents/globals do.

@domenic
Copy link
Member

domenic commented Mar 15, 2021

To actually solve this in the way @annevk prefers, we would probably need to switch the entire sandboxing flags infrastructure to be document based instead of BC-based. It sounds like that's a future goal of policy container (#4926), but not happening soon. /cc @ArthurSonzogni

In the meantime, I think we can make this better (in particular to help #1130) by computing "allowed to download" in the synchronous section. That appears to match what Chrome does: https://source.chromium.org/chromium/chromium/src/+/master:content/renderer/render_frame_impl.cc;l=5906-5922;drc=587068ee20325543d40cbd4bf50bed6af51ee23e

domenic added a commit that referenced this issue Mar 15, 2021
Helps with #1130 by removing a deep-in-the-algorithm-tree usage of source browsing context. Does not close #5597, but fixes the actual problems posed by the current architecture.
domenic added a commit that referenced this issue Mar 16, 2021
Helps with #1130 by removing a deep-in-the-algorithm-tree usage of source browsing context. Does not take care of #5597, but fixes the actual problems posed by the current architecture.
domenic added a commit that referenced this issue Mar 16, 2021
Helps with #1130 by removing a deep-in-the-algorithm-tree usage of source browsing context. Does not take care of #5597, but fixes the actual problems posed by the current architecture.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants