Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maybe not suggest creating a new process for a dedicated worker #4339

Closed
annevk opened this issue Feb 5, 2019 · 1 comment · Fixed by #5411
Closed

Maybe not suggest creating a new process for a dedicated worker #4339

annevk opened this issue Feb 5, 2019 · 1 comment · Fixed by #5411
Labels
clarification Standard could be clearer topic: agent The interaction with JavaScript's agent and agent cluster concepts topic: workers

Comments

@annevk
Copy link
Member

annevk commented Feb 5, 2019

We need to refactor this to create an agent for a dedicated worker inside the current agent cluster and to create a new agent cluster (belonging to the user agent) for shared workers (and service workers).

Credit: Chris Palmer.
@annevk annevk added topic: workers clarification Standard could be clearer labels Feb 5, 2019
@annevk annevk mentioned this issue Feb 13, 2019
Closed
@annevk annevk added the topic: agent The interaction with JavaScript's agent and agent cluster concepts label Feb 25, 2019
@gterzian gterzian mentioned this issue May 3, 2019
Open
domenic pushed a commit that referenced this issue Sep 9, 2019
@dtapuska @domenic
Imperatively allocate window agents and agent clusters
0404472 
Previously, the spec vaguely noted that all agents and agent clusters
must be allocated at the appropriate time.

With this change, similar-origin window agents are allocated
imperatively during document and browsing context creation, along with
their corresponding agent clusters. The agent clusters are stored in the
appropriate browsing context group, via a map keyed by scheme and
registrable domain.

Fixes #4361. Further work on imperative agent/agent cluster allocation,
specifically for workers and worklets, is tracked in #4339.
zcorpan pushed a commit that referenced this issue Nov 6, 2019
@dtapuska @zcorpan
Imperatively allocate window agents and agent clusters
2dda1ae 
Previously, the spec vaguely noted that all agents and agent clusters
must be allocated at the appropriate time.

With this change, similar-origin window agents are allocated
imperatively during document and browsing context creation, along with
their corresponding agent clusters. The agent clusters are stored in the
appropriate browsing context group, via a map keyed by scheme and
registrable domain.

Fixes #4361. Further work on imperative agent/agent cluster allocation,
specifically for workers and worklets, is tracked in #4339.
@annevk annevk mentioned this issue Jan 15, 2020
Closed
@domenic domenic mentioned this issue Mar 26, 2020
Merged
@domenic
Copy link
Member

domenic commented Mar 26, 2020

To add another cross-reference: this is referring to the sentence

Create a separate parallel execution environment (i.e. a separate thread or process or equivalent construct)

@annevk suggests that we solve this by solving #5210, i.e. remove all talk of implementation concepts, and instead only talk about agents and agent clusters.

As noted in #5396 the setting of [[CanBlock]] is the spec-level concept that most closely corresponds to "use an actual separate thread, not cooperative scheduling".

domenic added a commit that referenced this issue Mar 27, 2020
@domenic
Make all agent allocation imperative
760880f 
Closes #5210.

Closes #4339 by removing the explicit phrasing of a parallel execution
environment, instead relying on the agent infrastructure.

Closes #4988 by reintroducing a definition for "similar-origin window
agent", separate from its creation algorithm. Like the definition of all
agent types, it is now informal, just stating what globals are contained
in the agent.

Relocates the site-related definitions to the "Origin" section of the
spec, adjacent to the "schemelessly same site" and "same site"
definitions.

Exposes some of the higher-level concepts here to the dev edition.
@domenic domenic mentioned this issue Mar 27, 2020
Merged
domenic added a commit that referenced this issue Mar 31, 2020
@domenic
Make all agent allocation imperative
fe77096 
Closes #5210.

Closes #4339 by removing the explicit phrasing of a parallel execution
environment, instead relying on the agent infrastructure.

Closes #4988 by reintroducing a definition for "similar-origin window
agent", separate from its creation algorithm. Like the definition of all
agent types, it is now informal, just stating what globals are contained
in the agent.

Relocates the site-related definitions to the "Origin" section of the
spec, adjacent to the "schemelessly same site" and "same site"
definitions.

Exposes some of the higher-level concepts here to the dev edition.
domenic added a commit that referenced this issue Mar 31, 2020
@domenic
Make all agent allocation imperative
12a2a56 
Closes #5210.

Closes #4339 by removing the explicit phrasing of a parallel execution
environment, instead relying on the agent infrastructure.

Closes #4988 by reintroducing a definition for "similar-origin window
agent", separate from its creation algorithm. Like the definition of all
agent types, it is now informal, just stating what globals are contained
in the agent.

Relocates the site-related definitions to the "Origin" section of the
spec, adjacent to the "schemelessly same site" and "same site"
definitions.

Makes event loop creation explicit during agent creation, now that they
are 1:1 per #5396 and #5416.

Makes "responsible event loop" a convenience accessor, instead of one of
the core algorithms of environment settings objects. This means that
individual environment settings object definitions no longer need to
specify how to retrieve the responsible event loop.

Exposes some of the higher-level concepts here to the dev edition.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
clarification Standard could be clearer topic: agent The interaction with JavaScript's agent and agent cluster concepts topic: workers
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make all agent allocation imperative whatwg/html
2 participants
@domenic @annevk