Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove retargeting from :fullscreen pseudo-class #212

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nt1m
Copy link
Member

@nt1m nt1m commented Dec 19, 2022

Fixes #149

(See WHATWG Working Mode: Changes for more details.)


Preview | Diff

fullscreen.bs Outdated Show resolved Hide resolved
fullscreen.bs Outdated Show resolved Hide resolved
Co-authored-by: Anne van Kesteren <[email protected]>
@annevk
Copy link
Member

annevk commented Dec 19, 2022

This looks good to me modulo tests and implementation bugs, but would be great to hear from @rniwa as well.

@annevk annevk added topic: shadow Relates to shadow trees (as defined in DOM) do not merge yet Pull request must not be merged per rationale in comment labels Dec 19, 2022
@annevk
Copy link
Member

annevk commented Dec 21, 2022

Let's hold of on this for now given #149 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge yet Pull request must not be merged per rationale in comment topic: shadow Relates to shadow trees (as defined in DOM)
Development

Successfully merging this pull request may close these issues.

How :fullscreen CSS pseudo class works in shadow dom?
2 participants