Add "precustomized" custom element state #894

mfreed7 · 2020-09-16T17:43:45Z

Add the "precustomized" state needed by the HTML PR that prevents usage of attachInternals() prior to the constructor being run.

At least two implementers are interested (and none opposed):
- Chromium: me
- Safari: based on this comment
Tests are written and can be reviewed and commented upon at:
- Restrict attachInternals() to be run inside or after the constructor web-platform-tests/wpt#25402
Implementation bugs are filed:
- Chrome: Tracked as part of the declarative Shadow DOM tracking bug.
- Firefox: none yet
- Safari: none yet

💥 Error: 500 Internal Server Error 💥

PR Preview failed to build. (Last tried on Sep 28, 2020, 11:11 AM UTC).

More

PR Preview relies on a number of web services to run. There seems to be an issue with the following one:

🚨 CSS Spec Preprocessor - CSS Spec Preprocessor is the web service used to build Bikeshed specs.

🔗 Related URL

<html><body><p><strong>WARNING: </strong>mysqli_connect(): (HY000/2002): Can't connect to local MySQL server through socket '/var/run/mysqld/mysqld.sock' (111)</p></body></html>

If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.

annevk

Thanks, this looks good. And I guess also suggests we need a test for defined.

dom.bs

rniwa · 2020-09-23T08:22:17Z

dom.bs

-<dfn export id=concept-element-custom for=Element>custom</dfn>.
+"<code>undefined</code>", "<code>failed</code>", "<code>uncustomized</code>",
+"<code>precustomized</code>", or "<code>custom</code>". An <a for=/>element</a> whose <a
+for=Element>custom element state</a> is "<code>uncustomized</code>", "<code>precustomized</code>",


This seems wrong. Why would a custom element be considered as defined before super() call is made in the constructor? This will be incompatible with the shipping behavior of custom elements.

I think I agree. I've removed "precustomized" from the definition of "defined".

@annevk do you still think there is a need for more testing of :defined?

I think we should have a test yes, to ensure that it does not match that.

Ok, I'll add a test that :defined doesn't match, pre-super().

So we already have a test for :defined during an upgrade, and I think it's good enough to catch problems here. Note a couple things:

:defined already doesn't match during an upgrade, even after super(), because the custom element state is only set to "custom" after the constructor completes.

Testing :defined prior to super() shouldn't be typical anyway, since you can't access this prior to super(). You could use an external reference to the element to test, of course, but that doesn't seem like it'd be common.

I'm sure I'm missing something here - please let me know what it is, and what you'd like me to test for. I can add a test for the second bullet above, but it doesn't seem terribly useful. It would catch the case where :defined matches prior to super() but stops matching it after super().

I added this additional testing, in case that's what you're looking for here.

Thanks, I think those asserts are helpful.

mfreed7 · 2020-09-25T04:04:43Z

Ok, I think I addressed everything here. Note that I did add "precustomized" to the definition of "custom element". I'm using that in my other PR.

dom.bs

Per the conversation here [1], there is a desire to add more testing of the :defined pseudo state, prior to the call to super(). Note that `this` is not accessible prior to super(), so the instance itself is used. Also note that :defined already does not match anywhere inside the constructor, for upgrades. [1] whatwg/dom#894 (comment) Bug: 1042130 Change-Id: I2372900981247ea5624e737d2597d004398de477

Per the conversation here [1], there is a desire to add more testing of the :defined pseudo state, prior to the call to super(). Note that `this` is not accessible prior to super(), so the instance itself is used. Also note that :defined already does not match anywhere inside the constructor, for upgrades. [1] whatwg/dom#894 (comment) Bug: 1042130 Change-Id: I2372900981247ea5624e737d2597d004398de477 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431558 Auto-Submit: Mason Freed <[email protected]> Commit-Queue: Kouhei Ueno <[email protected]> Reviewed-by: Kouhei Ueno <[email protected]> Cr-Commit-Position: refs/heads/master@{#810991}

Per the conversation here [1], there is a desire to add more testing of the :defined pseudo state, prior to the call to super(). Note that `this` is not accessible prior to super(), so the instance itself is used. Also note that :defined already does not match anywhere inside the constructor, for upgrades. [1] whatwg/dom#894 (comment) Bug: 1042130 Change-Id: I2372900981247ea5624e737d2597d004398de477 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431558 Auto-Submit: Mason Freed <[email protected]> Commit-Queue: Kouhei Ueno <[email protected]> Reviewed-by: Kouhei Ueno <[email protected]> Cr-Commit-Position: refs/heads/master@{#810991}

Change to DOM: whatwg/dom#894. Tests: web-platform-tests/wpt#25402.

… super(), a=testonly Automatic update from web-platform-tests Add testing of :defined prior to call to super() Per the conversation here [1], there is a desire to add more testing of the :defined pseudo state, prior to the call to super(). Note that `this` is not accessible prior to super(), so the instance itself is used. Also note that :defined already does not match anywhere inside the constructor, for upgrades. [1] whatwg/dom#894 (comment) Bug: 1042130 Change-Id: I2372900981247ea5624e737d2597d004398de477 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431558 Auto-Submit: Mason Freed <[email protected]> Commit-Queue: Kouhei Ueno <[email protected]> Reviewed-by: Kouhei Ueno <[email protected]> Cr-Commit-Position: refs/heads/master@{#810991} -- wpt-commits: 0e252e7d3d8f95725f6ae177148da85eac333ca2 wpt-pr: 25794

See whatwg/dom#894 and whatwg/html#5909 Differential Revision: https://phabricator.services.mozilla.com/D121564

Per the conversation here [1], there is a desire to add more testing of the :defined pseudo state, prior to the call to super(). Note that `this` is not accessible prior to super(), so the instance itself is used. Also note that :defined already does not match anywhere inside the constructor, for upgrades. [1] whatwg/dom#894 (comment) Bug: 1042130 Change-Id: I2372900981247ea5624e737d2597d004398de477 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431558 Auto-Submit: Mason Freed <[email protected]> Commit-Queue: Kouhei Ueno <[email protected]> Reviewed-by: Kouhei Ueno <[email protected]> Cr-Commit-Position: refs/heads/master@{#810991} GitOrigin-RevId: cae287a3d5a71aa359c7c9d2e238a18f0babf37a

Add "precustomized" state

9318a88

mfreed7 mentioned this pull request Sep 16, 2020

Prevent attachInternals() use before custom element constructor whatwg/html#5909

Merged

3 tasks

annevk reviewed Sep 17, 2020

View reviewed changes

dom.bs Outdated Show resolved Hide resolved

dom.bs Outdated Show resolved Hide resolved

rniwa reviewed Sep 23, 2020

View reviewed changes

mfreed7 added 2 commits September 24, 2020 20:39

Address review comments

f63d8cf

Custom element definition should include "precustomized"

cf4f0db

rniwa reviewed Sep 25, 2020

View reviewed changes

dom.bs Outdated Show resolved Hide resolved

Remove precustomized from "custom" definition

ee36e05

chromium-wpt-export-bot mentioned this pull request Sep 25, 2020

Add testing of :defined prior to call to super() web-platform-tests/wpt#25794

Merged

formatting

7431705

annevk approved these changes Sep 28, 2020

View reviewed changes

annevk merged commit f837ce1 into whatwg:master Sep 28, 2020

annevk pushed a commit to whatwg/html that referenced this pull request Sep 28, 2020

Prevent attachInternals() use before custom element constructor

16667c3

Change to DOM: whatwg/dom#894. Tests: web-platform-tests/wpt#25402.

mfreed7 added a commit to mfreed7/html that referenced this pull request Oct 2, 2020

Prevent attachInternals() use before custom element constructor

3c64468

Change to DOM: whatwg/dom#894. Tests: web-platform-tests/wpt#25402.

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Aug 10, 2021

Bug 1723521 - Part 1: Add "precustomized" custom element state; r=smaug

8a6f168

See whatwg/dom#894 and whatwg/html#5909 Differential Revision: https://phabricator.services.mozilla.com/D121564

jamienicol pushed a commit to jamienicol/gecko that referenced this pull request Aug 20, 2021

Bug 1723521 - Part 1: Add "precustomized" custom element state; r=smaug

314227d

See whatwg/dom#894 and whatwg/html#5909 Differential Revision: https://phabricator.services.mozilla.com/D121564

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add "precustomized" custom element state #894

Add "precustomized" custom element state #894

mfreed7 commented Sep 16, 2020 •

edited by pr-preview bot

Loading

annevk left a comment

rniwa Sep 23, 2020

mfreed7 Sep 25, 2020

annevk Sep 25, 2020

mfreed7 Sep 25, 2020

mfreed7 Sep 25, 2020

mfreed7 Sep 25, 2020

annevk Sep 28, 2020

mfreed7 commented Sep 25, 2020

Add "precustomized" custom element state #894

Add "precustomized" custom element state #894

Conversation

mfreed7 commented Sep 16, 2020 • edited by pr-preview bot Loading

💥 Error: 500 Internal Server Error 💥

annevk left a comment

Choose a reason for hiding this comment

rniwa Sep 23, 2020

Choose a reason for hiding this comment

mfreed7 Sep 25, 2020

Choose a reason for hiding this comment

annevk Sep 25, 2020

Choose a reason for hiding this comment

mfreed7 Sep 25, 2020

Choose a reason for hiding this comment

mfreed7 Sep 25, 2020

Choose a reason for hiding this comment

mfreed7 Sep 25, 2020

Choose a reason for hiding this comment

annevk Sep 28, 2020

Choose a reason for hiding this comment

mfreed7 commented Sep 25, 2020

mfreed7 commented Sep 16, 2020 •

edited by pr-preview bot

Loading