Support databendwritter #717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wgzhao 如果有时间请帮忙 review 本 pr。 |
感谢提供 PR，代码质量非常好，有很多值得我学习的地方。 |
好的，已经按照这里提到的style 做了 format https://github.com/wgzhao/Addax/blob/master/README_zh.md#%E4%BB%A3%E7%A0%81%E9%A3%8E%E6%A0%BC |
我增加了一些代码评审，主要是变量命名风格统一的问题，麻烦看下 |
请问是否是没有将评审内容发出来？我这边看不到相应的comment。 |
wgzhao
reviewed
Dec 23, 2022
...riter/src/main/java/com/wgzhao/addax/plugin/writer/databendwriter/DatabendWriterOptions.java
Outdated
Show resolved
Hide resolved
...tabendwriter/src/main/java/com/wgzhao/addax/plugin/writer/databendwriter/DatabendWriter.java
Outdated
Show resolved
Hide resolved
...riter/src/main/java/com/wgzhao/addax/plugin/writer/databendwriter/DatabendWriterOptions.java
Outdated
Show resolved
Hide resolved
现在能看到吗？ |
|
Thanks @TCeason |
wgzhao
pushed a commit
that referenced
this pull request
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Databend 是一个开源弹性和工作负载感知的现代云数据仓库。
本pr主要内容为支持 databendwriter
#713