[update][reader][mongodbreader] Refactor connection item from list …

…to string Updated the `connection` field to be a string instead of a list. This change simplifies the data structure and improves readability.
wgzhao · Oct 9, 2024 · 8ef27e9 · 8ef27e9
1 parent 283f1b9
commit 8ef27e9
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 13 deletions.
diff --git a/docs/assets/jobs/mongoreader.json b/docs/assets/jobs/mongoreader.json
@@ -10,16 +10,14 @@
       "reader": {
         "name": "mongodbreader",
         "parameter": {
-          "connection": [
-            {
-              "address": [
-                "127.0.0.1:27017"
-              ],
-              "database": "tag_per_data",
-              "collection": "tag_data",
-              "authDb": "admin"
-            }
-          ],
+          "connection": {
+            "address": [
+              "127.0.0.1:27017"
+            ],
+            "database": "tag_per_data",
+            "collection": "tag_data",
+            "authDb": "admin"
+          },
           "username": "",
           "password": "",
           "column": [

diff --git a/...ngodbreader/src/main/java/com/wgzhao/addax/plugin/reader/mongodbreader/MongoDBReader.java b/...ngodbreader/src/main/java/com/wgzhao/addax/plugin/reader/mongodbreader/MongoDBReader.java
@@ -91,7 +91,7 @@ public void init()
                 password = EncryptUtil.decrypt(password.substring(6, password.length() - 1));
                 originalConfig.set(Key.PASSWORD, password);
             }
-            Configuration connConf = Configuration.from(originalConfig.getList(CONNECTION, Object.class).get(0).toString());
+            Configuration connConf = originalConfig.getConfiguration(CONNECTION);
             String database = connConf.getNecessaryValue(DATABASE, REQUIRED_VALUE);
             String authDb = connConf.getString(KeyConstant.MONGO_AUTH_DB, database);
             List<Object> addressList = connConf.getList(KeyConstant.MONGO_ADDRESS, Object.class);
@@ -248,7 +248,7 @@ public void init()
             this.upperBound = readerSliceConfig.get(KeyConstant.UPPER_BOUND);
             this.isObjectId = readerSliceConfig.getBool(KeyConstant.IS_OBJECT_ID);
 
-            Configuration connConf = Configuration.from(readerSliceConfig.getList(CONNECTION, Object.class).get(0).toString());
+            Configuration connConf = readerSliceConfig.getConfiguration(CONNECTION);
             this.database = connConf.getString(DATABASE);
             this.collection = connConf.getString(KeyConstant.MONGO_COLLECTION_NAME);
             String authDb = connConf.getString(KeyConstant.MONGO_AUTH_DB, this.database);

diff --git a/.../src/main/java/com/wgzhao/addax/plugin/reader/mongodbreader/util/CollectionSplitUtil.java b/.../src/main/java/com/wgzhao/addax/plugin/reader/mongodbreader/util/CollectionSplitUtil.java
@@ -47,7 +47,7 @@ public static List<Configuration> doSplit(Configuration originalSliceConfig, int
 
         List<Configuration> confList = new ArrayList<>();
 
-        Configuration connConf = Configuration.from(originalSliceConfig.getList(CONNECTION, Object.class).get(0).toString());
+        Configuration connConf = originalSliceConfig.getConfiguration(CONNECTION);
         String dbName = connConf.getString(DATABASE);
 
         String collName = connConf.getString(KeyConstant.MONGO_COLLECTION_NAME);