[bugfix][plugin][s3writer]S3writer:don't submit upload when no record…

… to write
wgzhao · Nov 25, 2024 · 345deb6 · 345deb6
1 parent 50e5a92
commit 345deb6
Showing 1 changed file with 18 additions and 14 deletions.
diff --git a/plugin/writer/s3writer/src/main/java/com/wgzhao/addax/plugin/writer/s3writer/S3Writer.java b/plugin/writer/s3writer/src/main/java/com/wgzhao/addax/plugin/writer/s3writer/S3Writer.java
@@ -307,22 +307,26 @@ public void startWrite(RecordReceiver lineReceiver)
                 completedParts.add(completedPart);
                 outputStream.reset();
             }
-            // Finally, call completeMultipartUpload operation to tell S3 to merge all uploaded
-            // parts and finish the multipart operation.
-            CompletedMultipartUpload completedMultipartUpload = CompletedMultipartUpload.builder()
-                    .parts(completedParts)
-                    .build();
+            if(!completedParts.isEmpty()) {
+                // Finally, call completeMultipartUpload operation to tell S3 to merge all uploaded
+                // parts and finish the multipart operation.
+                CompletedMultipartUpload completedMultipartUpload = CompletedMultipartUpload.builder()
+                        .parts(completedParts)
+                        .build();
 
-            CompleteMultipartUploadRequest completeMultipartUploadRequest =
-                    CompleteMultipartUploadRequest.builder()
-                            .bucket(bucket)
-                            .key(object)
-                            .uploadId(uploadId)
-                            .multipartUpload(completedMultipartUpload)
-                            .build();
+                CompleteMultipartUploadRequest completeMultipartUploadRequest =
+                        CompleteMultipartUploadRequest.builder()
+                                .bucket(bucket)
+                                .key(object)
+                                .uploadId(uploadId)
+                                .multipartUpload(completedMultipartUpload)
+                                .build();
 
-            s3Client.completeMultipartUpload(completeMultipartUploadRequest);
-            LOG.info("end do write");
+                s3Client.completeMultipartUpload(completeMultipartUploadRequest);
+                LOG.info("end do write");
+            } else {
+                LOG.info("no content do write");
+            }
         }
 
         private String record2String(Record record)