Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TabletopTableDetector pipeline parameters ignored #23

Open
corot opened this issue May 4, 2015 · 3 comments
Open

TabletopTableDetector pipeline parameters ignored #23

corot opened this issue May 4, 2015 · 3 comments

Comments

@corot
Copy link

corot commented May 4, 2015

I noticed that if you remove the tabletop_detector/clusterer dictionary level, it works. E.g.

pipeline1:
  type: TabletopTableDetector
  module: 'object_recognition_tabletop'
  inputs: [source1]
  outputs: [sink1]
  parameters:
    # table detector
    min_table_size: 5000
    plane_threshold: 0.01
    table_cluster_tolerance: 0.01
    vertical_frame_id: '/map'
    # clusterer
    z_crop: 0.25  # The amount to keep in the z direction relative to the coordinate frame defined by the pose (def. 0.5)
    z_min:  0.002 # The amount to crop above the plane, in meters (def. 0.0075)
    cluster_distance: 0.01  # The maximum distance between a point and the cluster it belongs to (def. 0.02)
    min_cluster_size: 300   # Min number of points for a cluster (def. 300)
@corot
Copy link
Author

corot commented May 4, 2015

I have just noticed that the detection documentation is updated, so only tabletop tutorial and examples must be updated

@dornhege
Copy link

dornhege commented Sep 2, 2015

For the TabletopObjectDetector at least the threshold parameter is not connected to the parameter in the code. I haven't checked the other, but suspect the same.

@corot
Copy link
Author

corot commented Nov 5, 2015

I think the only really used is 'tabletop_object_ids'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants