Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mokapot sub commands and brew() restructuring #110

Open
4 tasks
gessulat opened this issue Oct 4, 2023 · 0 comments
Open
4 tasks

Mokapot sub commands and brew() restructuring #110

gessulat opened this issue Oct 4, 2023 · 0 comments

Comments

@gessulat
Copy link
Contributor

gessulat commented Oct 4, 2023

Mokapot is a workflow that broadly consists of the following steps

  • data preprocessing: optionally subsetting the input data and then doing a 3-fold split to tho generate training data
  • model training: using the semi-supervised Percolator algorithm to train a classification model on the training data
  • confidence assignment: the models scores are used to calculate q-values and assign confidence values to the input

As a user it is convenient to have the workflow in a single CLI that executes all steps end-to-end.
As a developer it would be convenient to have the option to run the three steps separately.
This would allow for easier separation in integration tests and easier evaluate ideas such as: How well does this pretrained model perform for a different dataset?

One way would be to introduce sub commands:

  • mokapot preprocess /input/data.x /preprocessed/training/data [--max_subset]
  • mokapot train /preprocessed/training/data /trained/model [--max_iterations]
  • mokapot confidence /trained/model /output/results.x

Tasks

  • scout which python module can help with adding sub-commands to clis
  • spec out input and outputs for each sub-command and document it
  • break down mokapot.brew into the three steps
  • re-use the steps in mokapot.brew to add them as separate sub-commands, respectively
@gessulat gessulat changed the title Mokapot sub commands Mokapot sub commands and brew() restructuring Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant