Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete Control key interpretation #24

Closed
wants to merge 1 commit into from
Closed

Conversation

Lompik
Copy link
Contributor

@Lompik Lompik commented Mar 2, 2019

example key currently lacking:

  • Ctrl+[ sends escape
  • Ctrl+Space /Ctrl+2 sends null

As of now, both xkbcommon/glutin do not interpret those (they could).

@wez
Copy link
Owner

wez commented Mar 2, 2019

Thanks for continuing to contribute!
I think this X11 specific translation should happen in the xwindows layer because I'm concerned that this change might break translation in the glutin flavors of things.
Also: I've been thinking a little bit about making a user-configurable key binding configuration and processing layer that will need to sit at the layer above terminalstate for reasons alluded to in the changes I've recently pushed regarding the mux component.

I'd like your input on that but need a little bit more time to form some ideas; I'll open an issue with those thoughts when I have some time to write them down so that you'll have an opportunity to weigh in before code gets written for that.

In the meantime though, would you mind moving these translations up to xwin.rs?
Hopefully we can preserve the mappings as-is in terminalstate; ideally we won't unintentionally change the behavior of the other platforms/glutin with this PR.

@Lompik
Copy link
Contributor Author

Lompik commented Mar 4, 2019

My intent here is not to push X11 specific stuff everywhere. I do believe those keys needs translation regardless of the platform. I reckon I don't have a windows/macos to test this out though.
I'll close this for now, we can revisit later as needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants