Add support for blesh hooks #1572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I played a bit around with it and jumping from prompt to prompt works like a charm. |
|
Thanks! |
akinomyoga
reviewed
Jan 22, 2022
| __wezterm_install_bash_prexec | ||
| # blesh provides it's own preexec mechanism which is recommended over bash-preexec | ||
| # See https://github.com/akinomyoga/ble.sh/wiki/Manual-%C2%A71-Introduction#user-content-fn-blehook for more details | ||
| if [[ ! -v BLE_VERSION ]]; then |
There was a problem hiding this comment.
[[ -v var ]] is Bash 4.2 feature. Unfortunately, this will produce error messages in lower versions of Bash such as Bash 3.2 in macOS. [[ ! ${BLE_VERSION-} ]] is the way that works in all the versions of Bash 3.0+.
There was a problem hiding this comment.
I pushed 78ea214 which uses the same -n "$foo" test that we use for testing for zsh
There was a problem hiding this comment.
Thanks. I usually don't give a damn about the ancient versions of Darwin.
wez
added a commit
that referenced
this pull request
Jan 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
blesh provides its own hooks which are better integrated into it. No need to duplicate the functionality and slow down the shell unnecessarily. See https://github.com/akinomyoga/ble.sh/wiki/Manual-%C2%A71-Introduction#user-content-fn-blehook