Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking URLs now causes CMD.EXE window to briefly pop-up #3288

Closed
pragma- opened this issue Mar 19, 2023 · 3 comments
Closed

Clicking URLs now causes CMD.EXE window to briefly pop-up #3288

pragma- opened this issue Mar 19, 2023 · 3 comments
Labels
bug Something isn't working fixed-in-nightly This is (or is assumed to be) fixed in the nightly builds. Windows Issue applies to Microsoft Windows

Comments

@pragma-
Copy link

pragma- commented Mar 19, 2023

What Operating System(s) are you seeing this problem on?

Windows

Which Wayland compositor or X11 Window manager(s) are you using?

No response

WezTerm version

WezTerm-windows-20230317-153901-2d255c2d

Did you try the latest nightly build to see if the issue is better (or worse!) than your current version?

Yes, and I updated the version box above to show the version of the nightly that I tried

Describe the bug

Since updating to the newest nightly to try the highlight option, any time I click a URL a CMD.EXE window briefly pops up and then quickly disappears. This behavior was not present in previous nightlies.

To Reproduce

Using Windows 10, start wezterm and click on a URL.

Configuration

no config

Expected Behavior

No CMD.EXE window should pop up when clicking URLs.

Logs

No response

Anything else?

No response

@pragma- pragma- added the bug Something isn't working label Mar 19, 2023
@wez wez added the Windows Issue applies to Microsoft Windows label Mar 19, 2023
@pragma- pragma- changed the title Click URLs now causes CMD.EXE window to briefly pop-up Clicking URLs now causes CMD.EXE window to briefly pop-up Mar 19, 2023
@wez
Copy link
Owner

wez commented Mar 19, 2023

This is a regression in the upstream open crate.
Byron/open-rs#63

wez added a commit that referenced this issue Mar 19, 2023
The upstream open crate keeps making stuff async/blocking/not-working on
windows, so this is a step towards removing this dependency.

refs: #3288
wez added a commit that referenced this issue Mar 19, 2023
@wez wez added the fixed-in-nightly This is (or is assumed to be) fixed in the nightly builds. label Mar 19, 2023
@wez
Copy link
Owner

wez commented Mar 19, 2023

This should be resolved now in main.

It typically takes about an hour before commits are available as nightly builds for all platforms. Linux builds are the fastest to build and are often available within about 20 minutes. Windows and macOS builds take a bit longer.

Please take a few moments to try out the fix and let me know how that works out. You can find the nightly downloads for your system in the wezterm installation docs.

If you prefer to use packages provided by your distribution or package manager of choice and don't want to replace that with a nightly download, keep in mind that you can download portable packages (eg: a .dmg file on macOS, a .zip file on Windows and an .AppImage file on Linux) that can be run without permanently installing or replacing an existing package, and can then simply be deleted once you no longer need them.

If you are eager and can build from source then you may be able to try this out more quickly.

@pragma- pragma- closed this as completed Mar 20, 2023
@github-actions
Copy link
Contributor

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working fixed-in-nightly This is (or is assumed to be) fixed in the nightly builds. Windows Issue applies to Microsoft Windows
Projects
None yet
Development

No branches or pull requests

2 participants