Skip to content

make watchBlockNumber work with genesis blocks #3928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jxom merged 2 commits into from
Sep 5, 2025
Merged

make watchBlockNumber work with genesis blocks #3928

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
919d94b
make `watchBlockNumber` work with genesis blocks
fubhy Sep 5, 2025
1cb1e1a
Create many-yaks-collect.md
jxom Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/many-yaks-collect.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"viem": patch
---

Tweaked `watchBlockNumber` to work with genesis blocks
7 changes: 5 additions & 2 deletions src/actions/public/watchBlockNumber.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ export function watchBlockNumber<
'getBlockNumber',
)({ cacheTime: 0 })

if (prevBlockNumber) {
if (prevBlockNumber !== undefined) {
// If the current block number is the same as the previous,
// we can skip.
if (blockNumber === prevBlockNumber) return
Expand All @@ -145,7 +145,10 @@ export function watchBlockNumber<

// If the next block number is greater than the previous,
// it is not in the past, and we can emit the new block number.
if (!prevBlockNumber || blockNumber > prevBlockNumber) {
if (
prevBlockNumber === undefined ||
blockNumber > prevBlockNumber
) {
emit.onBlockNumber(blockNumber, prevBlockNumber)
prevBlockNumber = blockNumber
}
Expand Down
Loading