Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: issue 320 #322

Merged
merged 4 commits into from
Jul 23, 2020
Merged

fix: issue 320 #322

merged 4 commits into from
Jul 23, 2020

Conversation

z2014
Copy link
Collaborator

@z2014 z2014 commented Jul 22, 2020

aquariuslt
aquariuslt previously requested changes Jul 22, 2020
View reviewed changes
src/components/dialog/dialog.js Outdated Show resolved Hide resolved
@aquariuslt aquariuslt dismissed their stale review July 22, 2020 16:45

applied

aquariuslt
aquariuslt approved these changes Jul 22, 2020
View reviewed changes
Copy link
Collaborator

@aquariuslt aquariuslt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@z2014 z2014 merged commit 494113a into weui:master Jul 23, 2020
@z2014 z2014 mentioned this pull request Jul 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ettingshausen ettingshausen ettingshausen approved these changes

@aquariuslt aquariuslt aquariuslt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@z2014 @aquariuslt @ettingshausen