Fix for failing test for UTF-8 encoded filenames on Windows with R 3.5 #340
Conversation
|
I don't think that travis error is related to my changes -- it looks like the machine was just too busy. Let me know if you want me to investigate further. |
|
@hadley do we want to pull in accumulated R 3.5 fixes and make a 0.3.2 release? |
|
Yeah, I think that's a good idea. |
R/R/class.R
Outdated
| @@ -7,7 +7,7 @@ | |||
| #' @return An object of class \code{feather} | |||
| #' @export | |||
| feather <- function(path) { | |||
| path <- normalizePath(path, mustWork = TRUE) | |||
| path <- enc2native(path) | |||
There was a problem hiding this comment.
This is not an adequate replacement to normalisePath() as it won't replace ~
There was a problem hiding this comment.
Oh okay - new commit fixes the error but still normalizes. (FWIW the old code followed readxl's lead - tidyverse/readxl#477 takes out normalizePath())
Codecov Report
@@ Coverage Diff @@
## master #340 +/- ##
=========================================
- Coverage 78.33% 77.4% -0.94%
=========================================
Files 7 7
Lines 554 540 -14
=========================================
- Hits 434 418 -16
- Misses 120 122 +2
Continue to review full report at Codecov.
|
|
This PR was superseded, thanks! |
Adapts the same logic that fixed a similar problem in readxl because of the change in behavior of
normalizePaths()in R 3.5.