Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: implementions of announcement creation function #8715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implementions of announcement creation function #8715
Changes from 26 commits
6451ce7
b2fee4e
a2b50b2
5b5ddb8
26b3786
b9db316
4b9bcc0
7bc44a5
331794e
3064298
924d3e7
bbf853a
a6df789
9f992b9
f1b99be
12fdce9
ba7fad9
c15a124
fc4662d
d9f2013
bf6a25d
dbe2818
c83a629
c88e3ef
ca53ba1
7a28945
9cd6f18
f6de616
a8a2761
950f254
7eb1c6c
c60ac35
d560f70
bd33ca5
a87b1ca
615e657
1481713
6dc961f
7736dde
f52a5f5
c6893d4
45e69ac
b0f7239
c28c8a9
454b98b
42ff300
f459641
a7d1451
64ec309
98c1350
8223a29
dbfeb80
d65eb8d
8ffa562
deb5a6d
59ad97e
2b283a8
67cf149
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
req.paramsではpageIdが正しく取得できなかったため、この形にしています。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
クライアントのリクエスト方法がパスパラメーターで取得できるかたちになっていないのでは?
https://github.com/weseek/growi/pull/8715/files#diff-16e65c79c9018f437410fdf1211d572707905ec324e3b3129c795555aa364a5cR13
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/:id を用いることで、pageIdをパスパラメータで取得できるようにしました。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
これは現存する何かしらのバグの修正?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
はい。こちら現存するバグの修正です。
今回アナウンス機能の実装をしている中で、新規ユーザー作成リクエストを行ったときにadmin への通知が行われないことに気づき、修正しました。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#9434
こちらの PR で同様の修正をしたので取り込んでください