Merge bytecodealliance:dev/gc_refactor into wenyongh:dev/gc_refactor #831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And fix issues in AOT loader when loading GC defined types.
This PR implements the WebAssembly stringref proposal: https://github.com/WebAssembly/stringref It adds cmake variable `WAMR_BUILD_STRINGREF` to build the feature, which will enable GC automatically. The stringref contains two parts: - `part 1`: add new ref types in WasmGC, add opcode processing in loader and interpreter - `part 2`: add a library for string representation/encoding/decoding and so on To reduce the code size introduced to WAMR, this PR only includes `part 1`, `part 2` can be provided by embedder, they may use their own implementation, e.g., Wasmnizer-ts uses JSString from QuickJS to implement stringref: https://github.com/intel/Wasmnizer-ts/blob/main/runtime-library/stringref/stringref_qjs.c We will submit another PR of `part 2` and make it as a sample rather than WAMR core part. Signed-off-by: Su Yihan <[email protected]> Co-authored-by: Xu Jun <[email protected]>
Add ref type into ref type set when loading struct type's ref type maps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.