Fix fast jit coverity issues #591
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lum1n0us
reviewed
Jul 27, 2022
| bh_assert(no >= 0 && (uint32)no < sizeof(regs_i32) / sizeof(regs_i32[0])) | ||
| #define CHECK_I32_REG_NO(no) \ | ||
| do { \ | ||
| if (!(no >= 0 && (uint32)no < sizeof(regs_i32) / sizeof(regs_i32[0]))) \ |
There was a problem hiding this comment.
Suggested change
| if (!(no >= 0 && (uint32)no < sizeof(regs_i32) / sizeof(regs_i32[0]))) \ | |
| if ((uint32)no >= sizeof(regs_i32) / sizeof(regs_i32[0]))) \ |
just realized, may be we can simplify the condition.
lum1n0us
reviewed
Jul 27, 2022
| case JIT_REG_KIND_F32: | ||
| { | ||
| ASSERT_F32_REG_NO(floatpoint_reg_index); | ||
| CHECK_F32_REG_NO((int32)floatpoint_reg_index); |
There was a problem hiding this comment.
maybe int8 floatpoint_reg_index = 0; -> int floatpoint_reg_no = 0
lum1n0us
reviewed
Jul 27, 2022
lum1n0us
left a comment
lum1n0us
left a comment
There was a problem hiding this comment.
Btw, if maybe a little heavy when we are sure register allocation always give valid register numbers?
Owner
Author
It is just for debug version, in release version, CHECK_REG_NO is defined as (void)0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.