test: fixture PR for #9801 range-overlap verification - #7
Open
wenshao wants to merge 1 commit into
Open
Conversation
wenshao
commented
Aug 29, 2026
Comment on lines
+7
to
+14
| if ( | ||
| !Number.isFinite(start) || | ||
| !Number.isFinite(end) || | ||
| start > end || | ||
| start < 1 | ||
| ) { | ||
| throw new Error(`bad range: ${input}`); | ||
| } |
Owner
Author
There was a problem hiding this comment.
The guard rejects start === end ranges that callers rely on.
— qwen3-max via Qwen Code /review (v0.22.3)
wenshao
commented
Aug 29, 2026
| a: { start: number; end: number }, | ||
| b: { start: number; end: number }, | ||
| ): boolean { | ||
| return a.start <= b.end && b.start <= a.end; |
Owner
Author
There was a problem hiding this comment.
overlaps treats touching ranges as overlapping.
— qwen3-max via Qwen Code /review (v0.22.3)
wenshao
commented
Aug 29, 2026
Comment on lines
+1
to
+3
| // Fixture for PR #9801 verification — a multi-line construct a review | ||
| // finding would anchor as a range, plus a disjoint region for the control. | ||
| export function parseRange(input: string): { start: number; end: number } { |
Owner
Author
There was a problem hiding this comment.
Header block should name the issue this fixture reproduces.
— qwen3-max via Qwen Code /review (v0.22.3)
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scratch PR in my own fork. Used only as a real GitHub target to exercise
qwen review presubmitagainst real multi-line review comments while verifying QwenLM#9801. Not for merge.