-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP][text] add tokens #2201
Closed
Closed
[WIP][text] add tokens #2201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
这里有个小问题:
solution: |
第二个问题
solution: |
优先选择第二种,原因如下:
所以直接按照方案2,简洁 更通用 |
过度封装 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
after pr: #2186
hf 上 add token 和add special tokens 的联系和区别
1 都会加载到tokenizer里边,并且tokenzie的时候 新加的token不会被“split”
2 add special tokens 会把新的token变成tokenizer的property
比如:
之前讨论
我们只需要add_token就可以了,让模型own id就够了
TODO:
add tokens work with
- [x] tries (see: #2201 (comment))next pr