fix(bin): init_model API changed #2116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xingchensong
commented
Nov 6, 2023
| @@ -48,6 +49,8 @@ def init_model(configs): | |||
| def main(): | |||
|
|
|||
| args = get_args() | |||
| logging.basicConfig(level=logging.DEBUG, | |||
| format='%(asctime)s %(levelname)s %(message)s') | |||
| with open(args.config, 'r') as fin: | |||
| configs = yaml.load(fin, Loader=yaml.FullLoader) | |||
| model = init_model(configs) | |||
There was a problem hiding this comment.
这里增加logging是因为load_checkpoint里的logging.info需要初始化config，不然不会打印值
| @@ -132,7 +132,6 @@ def init_model(args, configs): | |||
| if args.checkpoint is not None: | |||
| infos = load_checkpoint(model, args.checkpoint) | |||
| elif args.enc_init is not None: | |||
| logging.info('load pretrained encoders: {}'.format(args.enc_init)) | |||
| infos = load_trained_modules(model, args) | |||
There was a problem hiding this comment.
load_trained_modules 里 有logging，这里去掉冗余log
robin1001
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jit and onnx work