[fix] Avoid problem during model averaging when there is parameter-tying. #2113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
汤老师，可以给具体例子吗？什么情况下是错的 |
|
pytorch dict 中共享参数的value如果是引用，确实是个问题 |
类似emb和lm_head之间的参数共享？ |
是，也有emb 和output.hidden，如果引用可能同一个参数会被平均多次 |
|
ok，got it, thx ! |
xingchensong
approved these changes
Nov 6, 2023
|
再比如，一个网络中两个 encoder，共用一个 GlobalCMVN，那么 encoder1.global_cmvn 与 encoder2.global_cmvn 虽然 key 不同，但指向同一个 memory，就会重复处理。
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.