Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[transformer] remove concat after to simplify the code flow #1762

Merged
merged 1 commit into from
Mar 20, 2023
Merged

[transformer] remove concat after to simplify the code flow #1762

merged 1 commit into from
Mar 20, 2023

Conversation

robin1001
Copy link
Collaborator

No description provided.

@robin1001
Copy link
Collaborator Author

We can still:

  • load the previous pretrained model.
  • decode works

image

@robin1001 robin1001 requested a review from xingchensong March 20, 2023 03:46
@robin1001
Copy link
Collaborator Author

@zwglory @yygle please pay attention to the PR, I think we can remove concat after in squeezeformer and efficient conformer.

@robin1001 robin1001 requested a review from pengzhendong March 20, 2023 03:50
@pengzhendong
Copy link
Member

wenet/wenet/bin/export_onnx_bpu.py

Line 545 in 4467198

assert module.concat_after is False

这行是不是要删掉

@robin1001
Copy link
Collaborator Author

wenet/wenet/bin/export_onnx_bpu.py

Line 545 in 4467198

assert module.concat_after is False

这行是不是要删掉

后面分模块去删除

@robin1001 robin1001 merged commit a95baf0 into main Mar 20, 2023
@robin1001 robin1001 deleted the binbin-concat-after branch March 20, 2023 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pengzhendong pengzhendong pengzhendong approved these changes

@xingchensong xingchensong Awaiting requested review from xingchensong

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robin1001 @pengzhendong