Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace open with pathlib.Path #519

Closed
wants to merge 2 commits into from
Closed

Replace open with pathlib.Path #519

wants to merge 2 commits into from

Conversation

blablatdinov
Copy link
Contributor

No description provided.

@blablatdinov
Copy link
Contributor Author

@sobolevn take a look

sobolevn
sobolevn reviewed Aug 12, 2024
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I have to decline this one. It does not solve a real problem we have:

  • This is neither a bug
  • Nor an optimization (Path is slower)

So, let's keep it as is. New code can introduce new bugs and changing something requires a reasoning :(

@sobolevn sobolevn closed this Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobolevn sobolevn sobolevn left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blablatdinov @sobolevn