Conversation
alexwlchan
reviewed
Aug 13, 2021
common/stacks/src/main/scala/weco/api/stacks/services/SierraService.scala
Show resolved
Hide resolved
common/stacks/src/main/scala/weco/api/stacks/services/SierraService.scala
Outdated
Show resolved
Hide resolved
common/stacks/src/main/scala/weco/api/stacks/services/SierraService.scala
Outdated
Show resolved
Hide resolved
common/stacks/src/main/scala/weco/api/stacks/services/SierraService.scala
Outdated
Show resolved
Hide resolved
common/stacks/src/test/scala/weco/api/stacks/services/SierraServiceTest.scala
Outdated
Show resolved
Hide resolved
common/stacks/src/test/scala/weco/api/stacks/services/SierraServiceTest.scala
Show resolved
Hide resolved
requests/src/main/scala/weco/api/requests/responses/LookupPendingRequests.scala
Outdated
Show resolved
Hide resolved
kenoir
force-pushed
the
update-requests-api
branch
from
e3c4f9f to
d96df29
Compare
kenoir
force-pushed
the
update-requests-api
branch
from
bd552fe to
9c6cee1
Compare
…atalogue-api into update-requests-api
…rvice.scala Co-authored-by: Alex Chan <a.chan@wellcome.org>
Contributor
Author
|
I think this could do with some more tests around the failure cases on |
…to update-requests-api
alexwlchan
reviewed
Aug 14, 2021
common/stacks/src/main/scala/weco/api/stacks/services/SierraService.scala
Outdated
Show resolved
Hide resolved
common/stacks/src/test/scala/weco/api/stacks/services/SierraServiceTest.scala
Outdated
Show resolved
Hide resolved
common/stacks/src/test/scala/weco/api/stacks/services/SierraServiceTest.scala
Outdated
Show resolved
Hide resolved
requests/src/main/scala/weco/api/requests/responses/LookupPendingRequests.scala
Show resolved
Hide resolved
requests/src/main/scala/weco/api/requests/responses/LookupPendingRequests.scala
Outdated
Show resolved
Hide resolved
…rvice.scala Co-authored-by: Alex Chan <a.chan@wellcome.org>
…rviceTest.scala Co-authored-by: Alex Chan <a.chan@wellcome.org>
This was referenced Aug 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Folllowing #224
Refactors the requests API to remove some potential bugs.