Improve lmc support for other arches #1108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 5124346390
💛 - Coveralls |
|
Looks good to me. I'll try to spend some time on this soon, see if I can bring it the last few steps. |
|
Thanks, I'd like to get aarch64 working before I merge it. From looking at the Fedora aarch64 test docs it looks like it needs to use UEFI to boot at all, but without a graphics console I couldn't figure out what was going wrong. We may need to add or change some of the settings for it, if that's the case they should be put into the QEMU dict to make it easier. |
bcl
force-pushed
the
master-qemu-arch
branch
from
b88176a
to
7639040
Compare
Require KVM acceleration to be disabled when, for example, building ARM images on x86_64.
Until we figure out how to enable it on other arches (just on aarch64 really).
When not using either KVM, or UEFI, make sure to still pass a decent machine as a default to qemu.
This should make it easier to support running lmc --virt-uefi on other arches. This also renames places using 'ovmf' a more correct 'fw_path' variable name. ovmf is the name of the x86_64 firmware, but other architectures use different names, so rename this to --firmware and 'fw_path', but leaving --ovmf-path as an alias.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.