fix: avoid where Self: 'a clause on GATs #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weiznich
reviewed
Sep 6, 2023
| @@ -341,4 +333,10 @@ pub trait AsyncConnection: SimpleAsyncConnection + Sized + Send { | |||
| fn transaction_state( | |||
| &mut self, | |||
| ) -> &mut <Self::TransactionManager as TransactionManager<Self>>::TransactionStateData; | |||
|
|
|||
| #[doc(hidden)] | |||
| fn _silence_lint_on_execute_future(_: Self::ExecuteFuture<'_, '_>) {} | |||
There was a problem hiding this comment.
Can you add a comment to these function explaining why they exist + linking to the relevant rust issues?
There was a problem hiding this comment.
Comment and link added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the
where Self: 'aclauses onAsyncConnection's associated types. The compiler over-eagerly asserts the trait should have the constraint but it is flawed when handling transactions generically. Dummy_silence_lint_on_*functions were added to convince the compiler the constraints are not required.Fixes: #104