Add properties to TestCase for the two other result-types #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cube707
commented
Oct 24, 2024
Comment on lines
367
to
378
| @result.setter | ||
| def result(self, value: Union[Result, List[Result]]): | ||
| # First remove all existing results | ||
| for entry in self.result: | ||
| if any(isinstance(entry, r) for r in POSSIBLE_RESULTS): | ||
| if isinstance(entry, tuple(POSSIBLE_RESULTS)): | ||
| self.remove(entry) | ||
| if isinstance(value, Result): | ||
| self.append(value) | ||
| elif isinstance(value, list): | ||
| for entry in value: | ||
| if any(isinstance(entry, r) for r in POSSIBLE_RESULTS): | ||
| if isinstance(entry, tuple(POSSIBLE_RESULTS)): | ||
| self.append(entry) |
There was a problem hiding this comment.
I don't get some of the guard in this code?
if passing in a single value it just needs to inherit from Result but passing a list will ignore all values that are not Failure | Error | Skipped? And why are values potentially not cleared from the previous content of self.result?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the two missing properties
is_failureandis_errorto theTestCaseclass. They are implemented identically to the existingis_skippedproperty.We are using
junitparserto fill a table with all testcases and it feels really inconsistent to have three different ways to check for success (directly from propriety), failure (checking two other proprieties are unset) and errors (isinstancecheck on results). So this Pr would make it much easier and consistent.created in cooperation with @jonahRo