Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NPE in DarkTreeExpansionAnimationListener #275

Closed
FSchumacher opened this issue Sep 17, 2021 · 1 comment · Fixed by #276
Closed

NPE in DarkTreeExpansionAnimationListener #275

FSchumacher opened this issue Sep 17, 2021 · 1 comment · Fixed by #276
Labels
bug Something isn't working

Comments

@FSchumacher
Copy link

Describe the bug
A NPE is thrown in DarkTreeExpansionAnimationListener$TreeStateAnimator.repaint

To Reproduce
A JMeter user posted in https://bz.apache.org/bugzilla/show_bug.cgi?id=65579 a description to reproduce, which I couldn't reproduce on my setup. But I believe it is due to an animation done on a tree that gets emptied while the animation happens.

Additional Information:

2021-09-17 21:34:36,173 ERROR o.a.j.JMeter: Uncaught exception in thread Thread[AWT-EventQueue-0,6,main]
java.lang.NullPointerException: null
	at com.github.weisj.darklaf.ui.tree.DarkTreeExpansionAnimationListener$TreeStateAnimator.repaint(DarkTreeExpansionAnimationListener.java:93) ~[darklaf-core-2.7.2.jar:2.7.2]
	at com.github.weisj.darklaf.ui.tree.DarkTreeExpansionAnimationListener$TreeStateAnimator.paintCycleEnd(DarkTreeExpansionAnimationListener.java:109) ~[darklaf-core-2.7.2.jar:2.7.2]
	at java.awt.event.InvocationEvent.dispatch(Unknown Source) ~[?:1.8.0_131]
	at java.awt.EventQueue.dispatchEventImpl(Unknown Source) ~[?:1.8.0_131]
	at java.awt.EventQueue.access$500(Unknown Source) ~[?:1.8.0_131]
	at java.awt.EventQueue$3.run(Unknown Source) ~[?:1.8.0_131]
	at java.awt.EventQueue$3.run(Unknown Source) ~[?:1.8.0_131]
	at java.security.AccessController.doPrivileged(Native Method) ~[?:1.8.0_131]
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source) ~[?:1.8.0_131]
	at java.awt.EventQueue.dispatchEvent(Unknown Source) ~[?:1.8.0_131]
	at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source) [?:1.8.0_131]
	at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source) [?:1.8.0_131]
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source) [?:1.8.0_131]
	at java.awt.EventDispatchThread.pumpEvents(Unknown Source) [?:1.8.0_131]
	at java.awt.EventDispatchThread.pumpEvents(Unknown Source) [?:1.8.0_131]
	at java.awt.EventDispatchThread.run(Unknown Source) [?:1.8.0_131]
  • OS: Version Windows 10 Home Chinese Version, Version number 21H1, Operating system internal version 19043.1165
  • Darklaf Version: 2.7.2

Additional context
None known
@FSchumacher FSchumacher added the bug Something isn't working label Sep 17, 2021
weisJ added a commit that referenced this issue Sep 17, 2021
@weisJ
Tree: Ensure animation is stopped when uninstalling
a80da43 
Fixes #275
@weisJ weisJ mentioned this issue Sep 17, 2021
Merged
weisJ added a commit that referenced this issue Sep 17, 2021
@weisJ
Tree: Ensure animation is stopped when uninstalling
6527662 
Fixes #275
weisJ added a commit that referenced this issue Sep 17, 2021
@weisJ
Tree: Ensure animation is stopped when uninstalling
c7ddc1d 
Fixes #275
@weisJ
Copy link
Owner

weisJ commented Sep 17, 2021

The fix for this issue and #274 are available in version 2.7.3

asfgit pushed a commit to apache/jmeter that referenced this issue Sep 18, 2021
@FSchumacher
Update Darklaf to 2.7.3
1e69fef 
The update of Darklaf to 2.7.2 came with a regression regarding tooltips
on linux and a NPE when playing an animation on JTrees.

weisJ/darklaf#274
weisJ/darklaf#275
Bugzilla Id: 65579
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Tree fixes weisJ/darklaf
2 participants
@FSchumacher @weisJ