Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LayerList refactoring / optimization #51

Merged
merged 5 commits into from
Jan 28, 2019

Conversation

chrismayer
Copy link
Collaborator

This PR optimizes the LayerList component:

  • Simplify UI template and data handling
  • Add click handler for layer items in LayerList, so the user can toggle the layer visibility by clicking the whole item (instead of just clicking the checkbox)
  • Separate LayerList and LayerListWin components

This simplifies the view template and the corresponding data handling in
the LayerList component.
This adds a click handler in order to toggle the layer's visibility
when clicking the layer item in the LayerList component. So the user
does not necessarily have to hit the checkbox to control the layer
visibility.
This ensures the OL map is injected in the father component even the
'ol-map-mounted' event has already been fired.
This splits the LayerList component into two separate components:
LayerList (the list itself)ynced with the map and the LayerListWin
(only a window holding the LayerList).
@chrismayer chrismayer merged commit ae9051f into wegue-oss:master Jan 28, 2019
@chrismayer chrismayer deleted the layerlist-optimization branch January 28, 2019 16:00
justb4 pushed a commit to Geolicious/wegue that referenced this pull request May 25, 2020
Support markdown in Feature Info Window.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant