Explicitly call 'npm run lint' in CI test pipeline #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This starts the linting process (npm run lint) explicitly in the CI test pipeline because the implicit call in the npm run test command does not break the pipeline, even if there are linting errors.
chrismayer
force-pushed
the
expl-lint-on-ci
branch
from
f7a4991
to
4fb9e93
Compare
|
Thanks for the review @JakobMiksch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This starts the linting process (
npm run lint) explicitly in the CI test pipeline because the implicit lint call in thenpm run testcommand does not break the pipeline, even if there are linting errors. So possible linting errors land in the Wegue code base if not discovered by human reviewers, which leads to a broken build.