Refactor app layout #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reworks the Wegue app template based on Vuetify components and layouts. Base for the new app is the Vuetify template 'complex' (https://github.com/vuetifyjs/vuetifyjs.com/blob/master/src/examples/layouts/complex.vue). The old toolbar concept has been ported unchanged and some minor components are missing at this point.
This reworks the component to show a help/about text, that the content is shown as a modal dialog (masked and not movable). Also the concept of an 'activator-slot' is used here, which makes the usage of the button more flexible (not just in the toolbar).
This introduces a new toolbar menu, which can contain several tools / modules (see wegue-oss#33). Herewith the dynamic creation of modules from the application context has been implemented. This was necessary because the slot-mechanism in the app-template used before wasn't enough to fill the menu and preserve the 'normal' toolbar buttons.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors / reworks the complete app layout. Therefore several things have been done:
Vuetifylayout componentsAboutwindow as modal dialogThis makes the tool creation more flexible and solves the problem that the tool-buttons cannot be shown on small screens.
Since this introduces changes in most of base components the current state has been preserved by the https://github.com/meggsimum/wegue/releases/tag/v0.4.0 release and a separate branch v0.4.x-maintenance.