Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize CI tests #344

Merged
merged 4 commits into from
Aug 21, 2023
Merged

Stabilize CI tests #344

merged 4 commits into from
Aug 21, 2023

Conversation

chrismayer
Copy link
Collaborator

@chrismayer chrismayer commented Aug 14, 2023

This PR fixes the package-lock.json, which was messed up since merging the PR #335, see #342 for details. The file is re-created with Node.js v16 and npm in v8. Since Node,js v14 has reached its end-of-life this PR also updates the engines within the package.json.

This also changes the CI test pipeline to use npm ci instead of npm i to have a reliable state in the tests. Kudos to @sronveaux , who proposed this idea in #343.

This fixes the package-lock.json, which was messed up since merging the
PR wegue-oss#335. The file is re-created with Node.js v16 and npm in v8.
@sronveaux
Copy link
Collaborator

Hi @chrismayer,

Thanks for the PR and kind word here, however, by running through Wegue repository I came across #294 opened by @JakobMiksch last year which was talking about the same issue... so it looks npm ci was already a concern which was put aside until Wegue V2 which means... now!

So kudos are not for me on this one ;-)

Copy link
Collaborator

@sronveaux sronveaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for potential detail about npm version where a decision should be taken, seems perfect on my side !

package.json Outdated Show resolved Hide resolved
@chrismayer
Copy link
Collaborator Author

Thanks for your review @sronveaux. I am going to merge now.

@chrismayer chrismayer merged commit a2035ee into wegue-oss:master Aug 21, 2023
1 check passed
@sronveaux
Copy link
Collaborator

Hi @chrismayer ,

Just thought about something here, I saw that the Dockerfile is also using npm install where it could use npm ci too...

This depends whether the docker implementation is aimed at development or at deployment. In the first case, it sould stay with npm install. In the second case, it should be changed to npm ci.

Can you give the underlying idea of the docker implementation to see whether it should be adapted or not ? I can make the adaptation if needed, I just tested it and it works flawlessly...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants