Add icons to MeasureTool type chooser buttons #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakobMiksch
approved these changes
Jul 19, 2023
Adds icons to the measure type chooser buttons in the MeasureTool module. Also adds a module property 'iconsOnly' to force showing icons only (no text) for the buttons.
chrismayer
force-pushed
the
measure-btn-icons
branch
from
1601987 to
cc2f1ce
Compare
|
Thanks for the review @JakobMiksch. I just rebased with current master and will merge now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #339. (see this diff for the relevant changeset)
This PR adds icons to the measure type chooser buttons in the
MeasureToolmodule:Also adds a module property
iconsOnlyto force showing icons only (no text) for the buttons:The get this set the module property
"iconsOnly": truein the module config within the
app-conf.json.