Update Vue to v2.7.14 LTS + Vuetify v2.6.15 #333
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spwoodcock
changed the title
|
Hi Sam, I don`t see any problem with PRs being built on top of each other, we used to follow the same approach with all the vue template upgrades. So, even if this incorporates #320, could you reopen #320 again? This will give us the opportunity to review and merge in changes in a more fine grained way. Cheers, |
spwoodcock
changed the title
|
No problem, I will re-open 👍 |
|
Merged |
|
Closed in favour of #335 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is built on top of #320, to allow for an easier single merge.
Apologies for this non-standard approach, but I couldn't think of a better way - these updates are reliant on the previous PR commits.
Closes #330.
v2.6.15. IMO, we shouldn't wait for Vuetifyv2.7LTS to be released, as Vuetify development can be painfully slow. It shouldn't really matter as2.7seems to be focused on "backports and deprecations from v3.0.0 to help developers prepare for v3 upgrade".Additional considerations:
npm installusing NPM v6, as v7 updates the lock file tolockfileVersion: 2. Ideally all developers should be using the same version of NPM, but this is hard to enforce. I considered updatingengines.npmin package.json to have a maximum version and creating a.npmrcwithengine-strict: true, but this may cause issues with downstream users.npm installinside anode:14docker container.lockfileVersion: 2), or NPM v8 (lockfileVersion: 3).devServer.portto0.0.0.0, as it allows more flexibility thanlocalhost.