Extend 'sidebar-toggle' event to force open state #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This extends the 'sidebar-toggle' event of the AppSidebar component, so the opening state of the sidebar can be forced (not just toggled). Done by passing a boolean argument when firing the event.
JakobMiksch
approved these changes
Feb 3, 2023
|
Thanks for the review @JakobMiksch. I am going to merge... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends the
'sidebar-toggle'event of theAppSidebarcomponent, so the opening state of the sidebar can be forced (not just toggled). Done by passing a boolean argument when firing the event. Harmonizes the signature / behavior with the'app-loading-mask-toggle'event, which does similar things.