-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to last Vue CLI v2 template #298
Conversation
…mplate. The biggest difference is updating to Webpack 3.x and using Webpack-dev-server instead of Express
…peerDeps and newer versions of NPM. This was already present before the latest updates though
thanks @sronveaux for the PRs, I am starting to review. One question right away. |
@sronveaux I ran Wegue with this setup and it works like expected great. |
@JakobMiksch thanks for the reply and the comments, that's good news to see that it works as expected !
The individual PRs are in fact cumulative. So for the code to be fully upgraded, you must apply this PR then the second one (#297).
Concerning the code formatting, there are two different reasons for that which you can find if you follow the GIT logs:
One last important thing is the package-lock.json file. Commit abbf7cc changes more than 30.000 files alone. It is if fact just a reset to the state before applying all the other commits. This was done to avoid some dependencies problems and is linked to the first comment of @fschmenger on #294. package-lock.json has to stay "outdated" for now as you start getting into trouble after the first upgrade to a newer file format. This is linked to Webpack V2.7 being used by Wegue when some of its dependencies are requiring Webpack V4. Because of this, newer versions of npm force you to use --legacy-peer-deps in order to install things correctly. This is solved by PR #297 Hope this makes sense, don't hesitate if you have more questions! |
As discussed with @chrismayer by mail a few months ago, I tried to upgrade Wegue to newer versions of Vue-CLI and Webpack (just to mention those two). See #94.
This project was going well until the end of April when I unfortunately had no more time to work on this. Here I had a little time again and managed to get almost to the end of it. So I think it's time to share...
I'll make a serie of PR, each going to the latest template used by the next Vue-CLI version.
For this one, nothing really big, it's just going to the latest template of Vue CLI V2. The major improvements are linked to a fully functional ESLint and an upgrade from Webpack 2.7 to Webpack 3.6.
This is also using Webpack-dev-server instead of running Express directly.
There is a bug here though in this version of the dev-server (which will be resolved in next PR with Vue-CLI V3) where compilation warnings issued while in dev mode are all reported as errors. So you can have the browser overlay report everything as errors or hide it completely (which I have done here). You can easily put it back on by going in the build/webpack.dev.conf.js file and change the overlay parameter, setting warnings to true instead of false.
I hope to post a PR for Vue V3 this afternoon, V4 should follow shortly and I still have to work a little bit on V5.
If you have ideas or requests to configure some things differently, don't hesitate to ask, I'll try to add what I can in coming PRs.