Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more rules to weaken linter in dev mode #271

Merged
merged 1 commit into from
Feb 2, 2022

Conversation

JakobMiksch
Copy link
Collaborator

@JakobMiksch JakobMiksch commented Jan 10, 2022

This pull request weakens more eslint rules when using dev-mode:

  • space-before-blocks
  • space-before-function-paren
  • object-curly-spacing

This helps to be more productive while making prototypes in Wegue. But of course, this does not affect the proper checking of rules when running npm run build.

Copy link
Collaborator

@chrismayer chrismayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @JakobMiksch .

OK for me.

@chrismayer
Copy link
Collaborator

Anyone else vetoing? Otherwise I am going to merge.

@fschmenger
Copy link
Collaborator

fschmenger commented Jan 18, 2022

This is appreciated from my side.
What do you guys think about just using syntax checking at all for dev-mode, e.g. by using esvalidate or some eslint recommended profile (not sure if the latter does exactly that)?

@JakobMiksch
Copy link
Collaborator Author

@fschmenger your suggestions sounds reasonable as well

@JakobMiksch JakobMiksch merged commit 8ef1a20 into wegue-oss:master Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants