Permalink layer exclusion #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe someone more familiar than me with the |
|
@justb4 do you want to have a look since the |
JakobMiksch
reviewed
Dec 21, 2021
JakobMiksch
approved these changes
Dec 22, 2021
|
@JakobMiksch Thanks for the review, Jakob! |
…h controls the usage of Permalink controller for layers. This replaces the previously used static ignore list.
…rty for mapLayers.
…luded from permanent links.
fschmenger
force-pushed
the
permalink_layer_exclusion
branch
from
80b7854
to
ff30942
Compare
|
This PR has been rebased to the current master to resolve documentation conflicts, there should be no changes. IMO we're good to merge this, but a quick review definitely can't hurt. :) |
|
I gave it a quick test and it seems to be fine 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch implements dynmical exclusion of layers from permalinks by means of a newly introduced layer attribute
supportsPermalink. The corresponding issue is described in #244 (resolves #244).I also added a documentation section for the
permalinkconfiguration, which did not exist yet.