-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Module property initialization #219
Module property initialization #219
Conversation
…. This will make additional module properties configurable through app-conf.json, e.g. 'title', 'icon' and sizing properties.
…g object to OlMeasureController.
…' module property. Provide backward compatibility.
…idable by app-conf.json.
This change only affects the properties declared in the 'modules' array of app-conf.json.
We could take the idea of this change-set a step further and consider to access the $appConfig only at top level program initialization. From there we could then rely on properties to pass the configuration through the component tree. IMO this would be nice, however requires a bit more work. |
Another little refactoring I propose would be to move the 'darkLayout' property from the individual modules and make it a global setting. Since the hamburger menu now shares the same background color as the toolbar and the window headers, there should be no drawbacks. This probably could be reviewed in conjunction with #202. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @fschmenger. This is an important step towards the encapsulation of modules as a pre-step for having a Wegue core library in the future.
Big thanks for also considering backwards compatibility again.
Also here gain for transparency: There will be some more PRs tackling some refactoring tasks. The last step will be to adjust the unit tests at once to avoid duplicate work, so it is a know issue that this (and some follow ups) will break the test suite of the master branch for a couple days. |
The purpose of this change-set is to forward the complete module configuration found in app-conf.json for each module. The configuration can then be picked up within each module via Vue props, rather than having to access the global $appConfig.modules.
The idea behind is: