[icycrystal4]

Summary

• improve browser-tool Linux recovery for cloud desktop environments
• inject Linux GUI session defaults in tool-cli using dynamic uid and Xauthority discovery
• reuse the default Chrome profile, support opening URLs on Linux, and extend cold-start attach waits
• avoid opening the extension options page for auto-loaded installs and align CLI Chrome detection with runtime behavior

Testing

• cd deps/browser/relay-server && npm run typecheck
• cd deps/browser/relay-server && npm run build
• validated on cloud hosts by installing published package versions and rerunning browser-tool tasks

Summary by CodeRabbit

• New Features

  • Enhanced Chrome process detection with PID verification to ensure Chrome is actually running
  • Added Linux GUI environment initialization for improved browser automation support

• Bug Fixes

  • Extension options page now opens only on initial installation
  • Improved connection timeouts that adapt based on Chrome's running state
  • Refined extension attachment instructions for end-users

• Version

  • Package version updated to 0.1.16

[coderabbitai]

📝 Walkthrough

Walkthrough

This PR updates the relay server package to version 0.1.16 and refactors Chrome process detection and launch logic across multiple files. Changes include conditional extension options page opening in the background script, improved SingletonLock-based process detection with PID validation, centralized Chrome launch arguments, and new Linux GUI environment setup helpers.

Changes

Cohort / File(s)	Summary
Extension Installation Behavior deps/browser/relay-server/chrome-extension/background.js	Conditional opening of options page—now only triggers when details.reason === 'install' and the active tab is not already the extensions page, replacing unconditional immediate open.
Package Metadata deps/browser/relay-server/package.json	Version bumped from 0.1.11 to 0.1.16.
Chrome Process Detection & Launch deps/browser/relay-server/src/cli.ts, deps/browser/relay-server/src/tool.ts	Replaced isChromeRunningWithProfile() with isChromeRunning() that inspects SingletonLock symlink targets to extract and validate PIDs via process.kill(). Introduced getChromeUserDataDir() for flexible profile directory resolution. Updated launchChrome() to skip launch if Chrome already running and use adaptive wait durations (5000/12000 ms) based on process state. Centralized launch arguments in getChromeLaunchArgs().
Linux GUI Environment Setup deps/browser/relay-server/src/tool-cli.ts	Added applyLinuxGuiEnvDefaults() to initialize GUI-dependent environment variables (DISPLAY, WAYLAND_DISPLAY, XDG_RUNTIME_DIR, DBUS_SESSION_BUS_ADDRESS, XAUTHORITY) for browser automation on Linux, invoked at main() startup.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~50 minutes

Poem

🐰 A hop through Chrome's relays we go,
PID checks and locks in sync now flow,
Linux screens awake with DISPLAY set,
The browser dances—version's on bet!

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 4.55% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The PR title 'fix: harden browser-tool linux recovery' accurately and concisely describes the main focus of the changeset: hardening Linux recovery for the browser-tool through improved Chrome detection, session initialization, and attach wait logic.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

🧹 Nitpick comments (2)

deps/browser/relay-server/src/tool-cli.ts (1)

33-50: Consider validating that the selected Xauthority file exists.

The function selects the lexicographically last .mutter-Xwaylandauth.* file, which works for typical naming patterns. However, there's no existence check before returning the path.

♻️ Optional: Add existence validation

 function resolveLinuxXauthority(): string | null {
   const runtimeDir = getLinuxRuntimeDir();

   try {
     const candidates = fs
       .readdirSync(runtimeDir)
       .filter((name) => name.startsWith(".mutter-Xwaylandauth."));

     if (candidates.length === 0) {
       return null;
     }

     candidates.sort();
-    return `${runtimeDir}/${candidates[candidates.length - 1]}`;
+    const selected = `${runtimeDir}/${candidates[candidates.length - 1]}`;
+    return fs.existsSync(selected) ? selected : null;
   } catch {
     return null;
   }
 }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@deps/browser/relay-server/src/tool-cli.ts` around lines 33 - 50, The
resolveLinuxXauthority function may return a path that no longer exists; after
selecting the lexicographically last candidate from candidates (from readdirSync
and filter), validate that the resolved path exists (e.g., via fs.existsSync or
fs.statSync) before returning it and otherwise return null; update
resolveLinuxXauthority to construct the fullPath (using getLinuxRuntimeDir() +
candidate) and verify existence, falling back to null if the file is missing.

deps/browser/relay-server/src/tool.ts (1)

83-118: Extract shared functions to a common module.

isChromeRunning() and getChromeUserDataDir() are duplicated nearly identically in cli.ts (lines 150-186). Consider extracting these to a shared utility module to avoid drift between implementations.

♻️ Suggested approach

Create a shared module like chrome-utils.ts:

// chrome-utils.ts
import * as fs from "node:fs";
import * as path from "node:path";
import * as os from "node:os";

export function getChromeUserDataDir(): string {
  const defaultDir = path.join(os.homedir(), ".config", "google-chrome");
  if (fs.existsSync(defaultDir)) {
    return defaultDir;
  }
  return path.join(os.homedir(), ".wegent-executor", "browser", "chrome-profile");
}

export function isChromeRunning(): boolean {
  const userDataDir = getChromeUserDataDir();
  const lockFile = path.join(userDataDir, "SingletonLock");
  try {
    const stats = fs.lstatSync(lockFile);
    if (!stats.isSymbolicLink() && !stats.isFile()) {
      return false;
    }

    if (stats.isSymbolicLink()) {
      const target = fs.readlinkSync(lockFile);
      const match = target.match(/-(\d+)$/);
      if (match) {
        try {
          process.kill(Number(match[1]), 0);
        } catch {
          try { fs.unlinkSync(lockFile); } catch { /* ignore */ }
          return false;
        }
      }
    }

    return true;
  } catch {
    return false;
  }
}

Then import from both tool.ts and cli.ts.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@deps/browser/relay-server/src/tool.ts` around lines 83 - 118,
isChromeRunning() and getChromeUserDataDir() are duplicated; extract them into a
shared utility module (e.g., chrome-utils.ts) that exports getChromeUserDataDir
and isChromeRunning, move the implementation from tool.ts into that module, then
replace the local implementations in both tool.ts and cli.ts with imports from
the new module (update any relative import paths accordingly) so both files call
the same exported functions.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@deps/browser/relay-server/src/tool-cli.ts`:
- Around line 33-50: The resolveLinuxXauthority function may return a path that
no longer exists; after selecting the lexicographically last candidate from
candidates (from readdirSync and filter), validate that the resolved path exists
(e.g., via fs.existsSync or fs.statSync) before returning it and otherwise
return null; update resolveLinuxXauthority to construct the fullPath (using
getLinuxRuntimeDir() + candidate) and verify existence, falling back to null if
the file is missing.

In `@deps/browser/relay-server/src/tool.ts`:
- Around line 83-118: isChromeRunning() and getChromeUserDataDir() are
duplicated; extract them into a shared utility module (e.g., chrome-utils.ts)
that exports getChromeUserDataDir and isChromeRunning, move the implementation
from tool.ts into that module, then replace the local implementations in both
tool.ts and cli.ts with imports from the new module (update any relative import
paths accordingly) so both files call the same exported functions.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8fb5fbe4-45bd-497c-9a82-e3831a98e22f

📥 Commits

Reviewing files that changed from the base of the PR and between 935c93b and f74b29a.

⛔ Files ignored due to path filters (1)

• deps/browser/relay-server/package-lock.json is excluded by !**/package-lock.json

📒 Files selected for processing (5)

• deps/browser/relay-server/chrome-extension/background.js
• deps/browser/relay-server/package.json
• deps/browser/relay-server/src/cli.ts
• deps/browser/relay-server/src/tool-cli.ts
• deps/browser/relay-server/src/tool.ts