Skip to content

fix(wework): prepare smart app builder before creation - #2843

Merged
qdaxb merged 1 commit into
mainfrom
fix/smart-app-builder-default-install
Aug 20, 2026
Merged

qdaxb merged 1 commit into
mainfrom
fix/smart-app-builder-default-install

Conversation

@qdaxb

@qdaxb qdaxb commented Aug 20, 2026 •

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • New Features

    • Smart App Builder is automatically prepared when starting a new Smart App.
    • Built-in marketplace plugins are installed automatically when missing.
    • Existing plugins disabled by the user remain disabled.
    • Creation controls now show installation progress and prevent duplicate actions.
  • Bug Fixes

    • Installation or preparation failures now display a clear message and keep you on the marketplace instead of opening an empty session.
  • Documentation

    • Updated architecture documentation to reflect marketplace registration and default-plugin installation flows.

@coderabbitai

coderabbitai Bot commented Aug 20, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: c16af3dd-7355-4493-a433-e98f8293dea0

📥 Commits

Reviewing files that changed from the base of the PR and between ac22b14 and f628d56.

📒 Files selected for processing (11)
  • docs/en/architecture/deepseek-harness-apps.md
  • docs/zh/architecture/deepseek-harness-apps.md
  • executor/src/runtime_work/handler/runtime_rpc.rs
  • executor/src/runtime_work/handler/tests.rs
  • wework/src-tauri/src/local_executor.rs
  • wework/src/i18n/locales/en/common.json
  • wework/src/i18n/locales/zh-CN/common.json
  • wework/src/pages/SmartAppsMarketplacePage.test.tsx
  • wework/src/pages/SmartAppsMarketplacePage.tsx
  • wework/src/tauri/localExecutor.test.ts
  • wework/src/tauri/localExecutor.ts

📝 Walkthrough

Walkthrough

The local executor now exposes bundled default plugins and reconciles their installation through config/read and plugin/install. The Smart Apps marketplace prepares smart-app-builder before queuing a trial, handles failures, and adds localized messages, tests, and architecture documentation.

Changes

Bundled Smart App installation

Layer / File(s) Summary
Allow config/read for plugin reconciliation
executor/src/runtime_work/handler/runtime_rpc.rs, executor/src/runtime_work/handler/tests.rs
The plugin app-server allowlist accepts config/read, and tests verify the method.
Expose bundled default plugins
wework/src-tauri/src/local_executor.rs
Bundled marketplace metadata includes sorted plugin names marked INSTALLED_BY_DEFAULT. Tests cover empty, filtered, and ordered results.
Reconcile and validate bundled plugins
wework/src/tauri/localExecutor.ts, wework/src/tauri/localExecutor.test.ts
The local executor reads configured plugins, installs missing defaults, preserves disabled configured plugins, and validates named bundled plugins before marketplace registration.
Gate Smart App creation on installation
wework/src/pages/SmartAppsMarketplacePage.tsx, wework/src/pages/SmartAppsMarketplacePage.test.tsx, wework/src/i18n/locales/*/common.json, docs/*/architecture/deepseek-harness-apps.md
The marketplace page prepares smart-app-builder before queuing its trial, prevents duplicate requests, displays progress and errors, and navigates only after success. Tests, translations, and architecture documentation cover the flow.

Estimated code review effort: 3 (Moderate) | ~30 minutes

Possibly related PRs

Suggested reviewers: luckjun529-lang, ficohu

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/smart-app-builder-default-install

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@qdaxb
qdaxb enabled auto-merge August 20, 2026 05:01
@qdaxb
qdaxb added this pull request to the merge queue Aug 20, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Aug 20, 2026
@qdaxb
qdaxb force-pushed the fix/smart-app-builder-default-install branch from b810f4e to f628d56 Compare August 20, 2026 05:20
@qdaxb
qdaxb merged commit 746ba70 into main Aug 20, 2026
27 of 28 checks passed
@qdaxb
qdaxb deleted the fix/smart-app-builder-default-install branch August 20, 2026 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant