Skip to content

test(wework): e2e cover application launches and MCP forms bugfix - #2774

Merged
qdaxb merged 2 commits into
wecode-ai:mainfrom
earthAlone2026:feature/sites-bugfix-and-e2e
Aug 18, 2026
Merged

qdaxb merged 2 commits into
wecode-ai:mainfrom
earthAlone2026:feature/sites-bugfix-and-e2e

Conversation

@earthAlone2026

@earthAlone2026 earthAlone2026 commented Aug 18, 2026 •

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • New Features

    • Added interactive MCP audience-selection forms during tasks.
    • Full access now uses granular approvals while preserving MCP interactions.
    • New and unspecified tasks default to Full access, with risk confirmation when switching modes.
    • Expanded Sites and Mini Program flows with plugin installation, draft, chip, and error validation.
  • Documentation

    • Added English and Chinese desktop E2E regression plans.
  • Tests

    • Added coverage for form responses, localized answers, approval behavior, and persisted evidence.

@coderabbitai

coderabbitai Bot commented Aug 18, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 659f015d-92d1-4f59-bf09-a7bf80fa91ce

📥 Commits

Reviewing files that changed from the base of the PR and between 9d62b72 and b4ab698.

📒 Files selected for processing (2)
  • executor/src/runtime_work/events.rs
  • wework/e2e/desktop/modules/desktop-build-flows.mjs
🚧 Files skipped from review as they are similar to previous changes (2)
  • executor/src/runtime_work/events.rs
  • wework/e2e/desktop/modules/desktop-build-flows.mjs

Included review availability: Your plan includes up to 4 reviews per rolling hour; 3 remain after this review.


📝 Walkthrough

Walkthrough

The change switches Full access to granular approval with MCP elicitation enabled. It adds runtime and contract tests, a stdio MCP fixture, desktop E2E coverage, application-plugin assertions, classification, and English and Chinese documentation.

Changes

Permission modes and MCP runtime

Layer / File(s) Summary
Granular approval and MCP interaction contract
executor/src/agents/..., executor/src/runtime_work/events.rs, executor/tests/..., docs/.../wework-codex-plugins.md
Full access now uses granular approval settings. Runtime tests cover MCP form conversion, localized answers, enum normalization, and app-server request policies.

Application plugin E2E

Layer / File(s) Summary
Application plugin E2E assertions
wework/e2e/desktop/modules/preferences-automation-flows.mjs, wework/src/App.plugins.test.tsx
Sites and Mini Program flows validate fresh tasks, Composer drafts, plugin chips, installation requests, localized display names, and error absence.

MCP desktop E2E

Layer / File(s) Summary
MCP fixture and permission-mode desktop flow
wework/e2e/desktop/modules/..., wework/e2e/utils/mcp-elicitation-server.mjs, docs/.../wework-applications-mcp-elicitation-e2e.md, .github/scripts/classify-wework-desktop-e2e.sh
The desktop flow configures an isolated MCP server, drives tool search and form elicitation, validates the owner response, persists JSONL evidence, captures screenshots, and assigns the scenario to the permission-modes segment.

Estimated code review effort: 4 (Complex) | ~45 minutes

Merge Risk: ⚪ Minimal · up to b4ab6

This change is merge-ready after normal checks and review; no actionable merge-blocking risk remains.

Sequence Diagram(s)

sequenceDiagram
  participant TaskFlow
  participant DesktopServer
  participant Codex
  participant MCPServer
  participant WeworkForm
  TaskFlow->>DesktopServer: Start mcp_elicitation scenario
  DesktopServer->>Codex: Request tool search and tool call
  Codex->>MCPServer: Invoke confirmation tool
  MCPServer->>WeworkForm: Request audience selection
  WeworkForm->>MCPServer: Submit owner
  MCPServer->>Codex: Return accepted result
  Codex->>TaskFlow: Return completion and evidence
Loading
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 30.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main changes: desktop E2E coverage for application launches and MCP elicitation forms.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@qdaxb
qdaxb added this pull request to the merge queue Aug 18, 2026
@qdaxb
qdaxb removed this pull request from the merge queue due to a manual request Aug 18, 2026
@qdaxb
qdaxb enabled auto-merge August 18, 2026 12:34
@qdaxb
qdaxb added this pull request to the merge queue Aug 18, 2026
Merged via the queue into wecode-ai:main with commit 8ad0c4b Aug 18, 2026
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants