Skip to content

fix(wework): keep guidance above composer - #2676

Merged
qdaxb merged 2 commits into
mainfrom
fix/wework-guidance-composer-layout
Aug 13, 2026
Merged

qdaxb merged 2 commits into
mainfrom
fix/wework-guidance-composer-layout

Conversation

@qdaxb

@qdaxb qdaxb commented Aug 13, 2026 •

Copy link
Copy Markdown
Contributor

What changed

  • remeasure mounted virtual message rows after an insertion, removal, or reorder changes message indexes
  • add a focused virtualization regression test for mid-turn guidance insertion
  • extend the desktop guidance E2E flow with a geometry assertion that guidance remains above the sticky composer
  • document the virtual conversation layout invariant in wework/DESIGN.md

Root cause

Applied runtime guidance splits the active turn and inserts messages into the middle of the virtualized transcript. The list only synchronously remeasured a non-final streaming assistant row, so rows whose indexes shifted could retain stale estimated sizes. The virtual container could then end before the final rendered row, allowing the sticky composer to stop in the middle of the transcript.

Impact

Runtime guidance and its following assistant continuation now remain in the conversation flow above the desktop composer.

Validation

  • pnpm --filter wework test src/components/chat/MessageList.test.tsx src/components/chat/MessageList.virtualization.test.tsx (149 tests passed)
  • focused Prettier and ESLint checks
  • node --check wework/e2e/desktop/modules/conversation-navigation.mjs
  • pre-push Wework ESLint, TypeScript, and full unit test checks
  • isolated real-Tauri verification of foreground runtime guidance and sticky composer placement

Summary by CodeRabbit

  • Bug Fixes

    • Improved conversation scrolling when messages are inserted, removed, or reordered.
    • Ensured newly displayed guidance messages remain visible above the floating composer.
    • Updated virtualized message lists to accurately recalculate row heights after streaming content changes.
  • Tests

    • Added regression coverage for message insertion and rendered-height recalculation.

@coderabbitai

coderabbitai Bot commented Aug 13, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 31510b15-a198-4ce8-a21b-5b63ba4381f1

📥 Commits

Reviewing files that changed from the base of the PR and between 362691f and b8f4518.

📒 Files selected for processing (4)
  • wework/DESIGN.md
  • wework/e2e/desktop/modules/conversation-navigation.mjs
  • wework/src/components/chat/MessageList.tsx
  • wework/src/components/chat/MessageList.virtualization.test.tsx

📝 Walkthrough

Walkthrough

Changes

Virtualized message layout

Layer / File(s) Summary
Detect and remeasure changed rows
wework/src/components/chat/MessageList.tsx
MessageList tracks visible message IDs, detects insertions, removals, and reordering, then remeasures affected rendered rows and updates differing virtualizer sizes.
Validate guidance placement
wework/src/components/chat/MessageList.virtualization.test.tsx, wework/e2e/desktop/modules/conversation-navigation.mjs, wework/DESIGN.md
Virtualization tests cover streaming insertion before a guidance row. End-to-end checks verify that visible guidance remains above the Composer. Design guidance documents the remeasurement and rendered-row requirements.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Mergeability Score: ⚪ Minimal · up to b8f45

The change keeps inserted guidance and its continuation above the desktop composer, with focused regression and geometry coverage. No actionable merge-blocking risk remains beyond normal checks and review.

Possibly related PRs

Suggested labels: ci:all

Suggested reviewers: micro66

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main fix: keeping runtime guidance above the desktop composer in Wework.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/wework-guidance-composer-layout

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@qdaxb
qdaxb added this pull request to the merge queue Aug 13, 2026
Merged via the queue into main with commit 19cd260 Aug 13, 2026
56 checks passed
@qdaxb
qdaxb deleted the fix/wework-guidance-composer-layout branch August 13, 2026 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant