Repository navigation
fix(wework): keep guidance above composer - #2676
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughChangesVirtualized message layout
Estimated code review effort: 3 (Moderate) | ~20 minutes Mergeability Score: ⚪ Minimal · up to The change keeps inserted guidance and its continuation above the desktop composer, with focused regression and geometry coverage. No actionable merge-blocking risk remains beyond normal checks and review. Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What changed
wework/DESIGN.mdRoot cause
Applied runtime guidance splits the active turn and inserts messages into the middle of the virtualized transcript. The list only synchronously remeasured a non-final streaming assistant row, so rows whose indexes shifted could retain stale estimated sizes. The virtual container could then end before the final rendered row, allowing the sticky composer to stop in the middle of the transcript.
Impact
Runtime guidance and its following assistant continuation now remain in the conversation flow above the desktop composer.
Validation
pnpm --filter wework test src/components/chat/MessageList.test.tsx src/components/chat/MessageList.virtualization.test.tsx(149 tests passed)node --check wework/e2e/desktop/modules/conversation-navigation.mjsSummary by CodeRabbit
Bug Fixes
Tests