Repository navigation
fix(wework): unify project space tooltips - #2607
Conversation
|
Warning Review limit reached
Next review available in: 45 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (8)
📝 WalkthroughWalkthroughThe shared ChangesTooltip adoption
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant TooltipTrigger
participant Tooltip
participant document.body
TooltipTrigger->>Tooltip: pointer enter
Tooltip->>document.body: render delayed portaled tooltip
Tooltip->>Tooltip: measure and clamp position
TooltipTrigger->>Tooltip: pointer leave or Escape
Tooltip->>document.body: remove tooltip
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@wework/src/components/ui/tooltip.tsx`:
- Around line 134-137: Update the tooltip className in the tooltip component to
remove whitespace-nowrap and add wrapping and word-breaking utilities, keeping
long unbroken labels such as entry.relative_path inside the max-width and
viewport padding. Read and follow DESIGN.md before making this UI behavior
change.
- Around line 23-25: Read DESIGN.md, then update the tooltip interaction
implementation around SHOW_DELAY_MS to record recent tooltip dismissal and apply
the required 300ms warm handoff when moving between nearby tooltips, while
preserving the existing 700ms delay for initial activation and the current
viewport padding and trigger gap behavior.
In `@wework/src/features/todo/CloudFilesView.tsx`:
- Around line 242-279: Replace the static Chinese tooltip and action labels with
the local `@/hooks/useTranslation` wrapper and add matching keys in both
src/i18n/locales/en/ and src/i18n/locales/zh-CN/. Apply this to
rename/open/delete labels in wework/src/features/todo/CloudFilesView.tsx:242-279
and delivery-file labels in CloudFilesView.tsx:310-341; member removal and
rename confirmation/cancellation labels in
wework/src/features/todo/CloudProjectManageView.tsx:485-495 and :607-624;
task-actions labels in wework/src/features/todo/CloudTodoBoardCard.tsx:179-193;
task-search and task-creation labels in
wework/src/features/todo/CloudTodoWorkspace.tsx:2098-2142; and column
task-creation labels in CloudTodoWorkspace.tsx:2419-2435.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 004b0403-b889-44fe-adc1-06a4cab43664
📒 Files selected for processing (10)
wework/DESIGN.mdwework/src/components/layout/DesktopWindowControls.tsxwework/src/components/ui/tooltip.test.tsxwework/src/components/ui/tooltip.tsxwework/src/features/todo/CloudFilesView.tsxwework/src/features/todo/CloudProjectManageView.tsxwework/src/features/todo/CloudProjectsHome.tsxwework/src/features/todo/CloudTodoBoardCard.tsxwework/src/features/todo/CloudTodoWorkspace.tsxwework/src/features/todo/ProjectSpaceChatSidebar.tsx
1ce0c4b to
41ffd4c
Compare
Summary
titletooltips and missing hints across project-space controls with the shared Tooltip componentaria-labelvalues and document the durable tooltip ruleRoot cause
Project-space controls used three different hint patterns: native browser titles, the shared Tooltip, or no visible hint. The shared Tooltip also rendered inside its trigger container, so overflow clipping prevented consistent reuse in compact panels.
Validation
pnpm --filter wework exec eslint <changed files>pnpm --filter wework typecheckpnpm --filter wework test src/components/ui/tooltip.test.tsx src/features/todo/CloudTodoWorkspace.test.tsx src/features/todo/ProjectSpaceChatSidebar.test.tsx(61 tests)pnpm --filter wework test src/features/todo/CloudFilesView.test.tsx127.0.0.1:8000Summary by CodeRabbit
New Features
Accessibility
Bug Fixes