Skip to content

fix(wework): collapse plugin picker in conversations - #2585

Merged
qdaxb merged 1 commit into
mainfrom
fix/collapse-conversation-plugin-picker
Aug 11, 2026
Merged

qdaxb merged 1 commit into
mainfrom
fix/collapse-conversation-plugin-picker

Conversation

@qdaxb

@qdaxb qdaxb commented Aug 11, 2026 •

Copy link
Copy Markdown
Contributor

What changed

  • Restore the conversation composer wiring that collapses the plugin picker to a single icon after a conversation starts.
  • Add a layout-level regression assertion for an active runtime task with an empty transcript and a wide toolbar.
  • Document the expanded-new-chat and collapsed-active-conversation behavior in Chinese and English.

Root cause

PR #2549 removed pluginPickerIconOnly={hasConversation} from the main conversation composer, so the picker kept rendering the expanded plugin preview chip even after entering a conversation.

User impact

Active conversations once again use the compact plugin icon while preserving access to the complete plugin picker. New chats still show the expanded preview.

Validation

  • pnpm --filter wework test src/components/layout/DesktopWorkbenchLayout.test.tsx -t "treats a selected runtime task with an empty transcript as a conversation"
  • pnpm --filter wework exec prettier --check src/components/layout/DesktopWorkbenchMain.tsx src/components/layout/DesktopWorkbenchLayout.test.tsx
  • pnpm --filter wework exec eslint src/components/layout/DesktopWorkbenchMain.tsx src/components/layout/DesktopWorkbenchLayout.test.tsx (no errors; one pre-existing warning)
  • Pre-push Wework ESLint, TypeScript, and unit tests

Summary by CodeRabbit

  • New Features
    • The plugin picker now shows up to three plugin previews when starting a new chat.
    • In active conversations and narrow toolbars, the picker collapses to a compact icon while remaining fully accessible.
  • Documentation
    • Updated English and Chinese developer guides to describe the plugin picker’s new display behavior.

@coderabbitai

coderabbitai Bot commented Aug 11, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 2c978da9-268e-460e-b296-5e3088bc2296

📥 Commits

Reviewing files that changed from the base of the PR and between ededabf and eb03c7e.

📒 Files selected for processing (4)
  • docs/en/wework/developer-guide/wework-codex-plugins.md
  • docs/zh/wework/developer-guide/wework-codex-plugins.md
  • wework/src/components/layout/DesktopWorkbenchLayout.test.tsx
  • wework/src/components/layout/DesktopWorkbenchMain.tsx

📝 Walkthrough

Walkthrough

The composer passes conversation state to control plugin picker presentation. Layout tests verify the compact icon-only mode. English and Chinese documentation describe preview behavior for new chats and icon behavior for active conversations and narrow toolbars.

Changes

Plugin picker presentation

Layer / File(s) Summary
Composer wiring, validation, and documentation
wework/src/components/layout/DesktopWorkbenchMain.tsx, wework/src/components/layout/DesktopWorkbenchLayout.test.tsx, docs/en/wework/developer-guide/wework-codex-plugins.md, docs/zh/wework/developer-guide/wework-codex-plugins.md
DesktopWorkbenchMain passes hasConversation through pluginPickerIconOnly. Layout tests verify h-7 w-7 sizing and no preview icons. Both guides describe new-chat previews and icon-only modes.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

Suggested reviewers: ficohu, luckjun529-lang, icycrystal4

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes collapsing the plugin picker in active conversations, which is the main change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/collapse-conversation-plugin-picker

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@qdaxb
qdaxb enabled auto-merge August 11, 2026 11:59
@qdaxb
qdaxb added this pull request to the merge queue Aug 11, 2026
Merged via the queue into main with commit c17768a Aug 11, 2026
50 checks passed
@qdaxb
qdaxb deleted the fix/collapse-conversation-plugin-picker branch August 11, 2026 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant