Repository navigation
fix(wework): collapse plugin picker in conversations - #2585
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThe composer passes conversation state to control plugin picker presentation. Layout tests verify the compact icon-only mode. English and Chinese documentation describe preview behavior for new chats and icon behavior for active conversations and narrow toolbars. ChangesPlugin picker presentation
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What changed
Root cause
PR #2549 removed
pluginPickerIconOnly={hasConversation}from the main conversation composer, so the picker kept rendering the expanded plugin preview chip even after entering a conversation.User impact
Active conversations once again use the compact plugin icon while preserving access to the complete plugin picker. New chats still show the expanded preview.
Validation
pnpm --filter wework test src/components/layout/DesktopWorkbenchLayout.test.tsx -t "treats a selected runtime task with an empty transcript as a conversation"pnpm --filter wework exec prettier --check src/components/layout/DesktopWorkbenchMain.tsx src/components/layout/DesktopWorkbenchLayout.test.tsxpnpm --filter wework exec eslint src/components/layout/DesktopWorkbenchMain.tsx src/components/layout/DesktopWorkbenchLayout.test.tsx(no errors; one pre-existing warning)Summary by CodeRabbit