Repository navigation
fix(wework): let app shell follow viewport - #2573
Merged
Merged
Conversation
qdaxb
enabled auto-merge
August 11, 2026 06:07
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe React app shell no longer derives layout dimensions from Tauri viewport events. Linux embedded WebViews now use a GTK overlay and fixed-position host. Tests and release guides document the updated window-surface constraints. ChangesWindow surface layout
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)sequenceDiagram
participant OpenCommand
participant EmbeddedBrowser
participant LinuxHost
participant GTKContainer
OpenCommand->>EmbeddedBrowser: create embedded WebView
EmbeddedBrowser->>LinuxHost: apply_bounds(position, size)
LinuxHost->>GTKContainer: find or create fixed host
GTKContainer-->>LinuxHost: place WebView at logical bounds
LinuxHost-->>EmbeddedBrowser: return placement result
EmbeddedBrowser-->>OpenCommand: close and return error on failure
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
qdaxb
added this pull request to the merge queue
Aug 11, 2026
qdaxb
removed this pull request from the merge queue due to a manual request
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
innerSize/scaleFactorsynchronization from the React app shellfixed inset-0Root cause
The app shell had two competing size sources. CSS already pinned it to the WebView viewport, while
useTauriViewportSizeasynchronously converted native resize events and wrote explicit inline dimensions. A stale native conversion could override the current CSS viewport after a resize, leaving part of the window unfilled.Impact
The Wework main surface now follows every WebView resize synchronously and cannot retain an older native width or height. Native window dimensions remain limited to window creation, restoration, and system-level window management.
Validation
pnpm --filter wework test src/App.plugins.test.tsx— 27 tests passedpnpm --filter wework exec prettier --check src/App.tsx src/App.plugins.test.tsxpnpm --filter wework exec eslint src/App.tsx src/App.plugins.test.tsxpnpm --filter wework typecheckpnpm --filter wework build1280x720 -> 1920x966 -> 1280x720 -> 1920x966; the app shell matched the viewport bounds after every resizeSummary by CodeRabbit
Bug Fixes
Documentation