Skip to content

test(wework): preserve sleep assertion identity - #2557

Merged
qdaxb merged 1 commit into
mainfrom
test/wework-sleep-assertion-identity
Aug 10, 2026
Merged

qdaxb merged 1 commit into
mainfrom
test/wework-sleep-assertion-identity

Conversation

@qdaxb

@qdaxb qdaxb commented Aug 10, 2026 •

Copy link
Copy Markdown
Contributor

What changed

  • retain the macOS sleep assertion IDs observed when the task starts
  • assert that closing the Wework window to the tray preserves the same assertion IDs

Why

This follows up on the review feedback from #2554. The previous E2E check proved that an assertion existed before and after closing to the tray, but it could not detect an incorrect release-and-recreate cycle while the task remained active.

Validation

  • pnpm --filter wework exec prettier --check e2e/desktop/task-flow.e2e.mjs
  • pnpm --filter wework exec eslint e2e/desktop/task-flow.e2e.mjs
  • pre-push Wework ESLint, TypeScript, and unit-test checks

Summary by CodeRabbit

  • Tests
    • Enhanced desktop task-flow coverage for macOS sleep-prevention behavior.
    • Verified that closing the window to the tray preserves active task protections and associated lifecycle evidence.

@coderabbitai

coderabbitai Bot commented Aug 10, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 98bd66ac-4443-4905-a33f-ce51563df9b9

📥 Commits

Reviewing files that changed from the base of the PR and between 324b2c2 and 73afd4b.

📒 Files selected for processing (1)
  • wework/e2e/desktop/task-flow.e2e.mjs

📝 Walkthrough

Walkthrough

The desktop lifecycle E2E test now records macOS sleep assertion IDs while a task runs and verifies that closing the window to the tray preserves those IDs.

Changes

Desktop lifecycle validation

Layer / File(s) Summary
Sleep assertion preservation check
wework/e2e/desktop/task-flow.e2e.mjs
The test stores sleep assertion IDs at the task-running stage and compares them with the IDs after the window closes to the tray.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested labels: ci:all

Suggested reviewers: lvmowei, earthalone2026, sdadunderscoresdad

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the test change that preserves macOS sleep assertion identity.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch test/wework-sleep-assertion-identity

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@qdaxb
qdaxb added this pull request to the merge queue Aug 10, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Aug 10, 2026
@qdaxb
qdaxb added this pull request to the merge queue Aug 10, 2026
Merged via the queue into main with commit 99afc4c Aug 10, 2026
47 checks passed
@qdaxb
qdaxb deleted the test/wework-sleep-assertion-identity branch August 10, 2026 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant