Skip to content

fix(wework): align dark theme toolbar colors - #2527

Merged
qdaxb merged 1 commit into
mainfrom
fix/wework-sidebar-icon-color
Aug 9, 2026
Merged

qdaxb merged 1 commit into
mainfrom
fix/wework-sidebar-icon-color

Conversation

@qdaxb

@qdaxb qdaxb commented Aug 9, 2026 •

Copy link
Copy Markdown
Contributor

What changed

  • use theme-aware semantic colors for shared desktop toolbar icons
  • align the sidebar collapse icon with the search and priority icons
  • correct dark-theme backgrounds and active states for the Open location and workspace panel controls
  • add regression coverage for normal and active toolbar states

Root cause

The desktop toolbar reused fixed light-theme hex colors and black hover/active overlays. In dark mode these values produced low-contrast icons and an overly dark Open location surface.

Validation

  • pnpm --dir wework exec vitest run src/components/layout/DesktopSidebar.test.tsx src/components/layout/workspace-panels/WorkspacePanelActions.test.tsx src/components/layout/EnvironmentInfoPopover.test.tsx src/test/theme-token-guard.test.ts (144 tests passed)
  • pnpm --filter wework typecheck
  • Prettier and ESLint on changed files
  • full pre-push ESLint, TypeScript, and Wework unit test suite
  • isolated real Tauri verification in dark mode for sidebar icons, toolbar icons, Open location, and open bottom/right panel states

Summary by CodeRabbit

  • Style

    • Updated sidebar, top bar, window controls, and workspace panel controls with theme-aware colors.
    • Improved hover, active, focus, selected, and muted-state styling for better visual consistency across themes.
  • Tests

    • Expanded coverage for sidebar typography and workspace panel states, including active and inactive styling.

@coderabbitai

coderabbitai Bot commented Aug 9, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: f4aea059-9f17-4e08-ab9f-bbe990bd45ae

📥 Commits

Reviewing files that changed from the base of the PR and between ed8dcf5 and a4ca611.

📒 Files selected for processing (6)
  • wework/src/components/layout/DesktopSidebar.test.tsx
  • wework/src/components/layout/DesktopSidebar.tsx
  • wework/src/components/layout/DesktopTopBar.tsx
  • wework/src/components/layout/DesktopWindowControls.tsx
  • wework/src/components/layout/workspace-panels/WorkspacePanelActions.test.tsx
  • wework/src/components/layout/workspace-panels/WorkspacePanelActions.tsx

📝 Walkthrough

Walkthrough

Desktop sidebar, top-bar, window-control, and workspace panel controls now use theme-based colors and shared button styling. Tests verify the updated sidebar and workspace panel classes.

Changes

Desktop theme controls

Layer / File(s) Summary
Desktop header control styling
wework/src/components/layout/DesktopTopBar.tsx, wework/src/components/layout/DesktopWindowControls.tsx, wework/src/components/layout/DesktopSidebar.tsx, wework/src/components/layout/DesktopSidebar.test.tsx
Desktop controls use theme color tokens. Window controls accept an optional buttonClassName. Sidebar tests verify normal and hover text colors.
Workspace panel theme styling
wework/src/components/layout/workspace-panels/WorkspacePanelActions.tsx, wework/src/components/layout/workspace-panels/WorkspacePanelActions.test.tsx
Workspace panel controls use theme-based muted surfaces and text states. Tests cover inactive, active, expanded, and titlebar styling.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: micro66, ficohu, icycrystal4

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: aligning Wework desktop toolbar colors with the dark theme.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/wework-sidebar-icon-color

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@qdaxb
qdaxb enabled auto-merge August 9, 2026 15:02
@qdaxb
qdaxb added this pull request to the merge queue Aug 9, 2026
Merged via the queue into main with commit 08d1d35 Aug 9, 2026
47 checks passed
@qdaxb
qdaxb deleted the fix/wework-sidebar-icon-color branch August 9, 2026 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant